Skip to content

Conversation

@ckwalsh
Copy link
Contributor

@ckwalsh ckwalsh commented Oct 20, 2025

I'm playing around with some parsing libraries to better understand them, and am using the pcgen pcc/lst files as my test targets.

This PR fixes a bunch of inconsistencies in pcc files that my parser ran into.

  • Missing http:// schemes in urls
  • Missing : in url schemes
  • Flipped month/year in SOURCEDATE properties
  • Duplicate SOURCEWEB / SOURCELONG / STATUS properties
  • Duplicate DESC properties
    • Concatenated them with a space to match LST behavior
  • Duplicate LOGO property in killshot.pcc
    • Checked which logo image shows up in my pcgen install, and deleted creative commons image file
  • Ensured local paths for SOURCEWEB and HELP start with .

@karianna karianna requested a review from LegacyKing October 23, 2025 00:25
@ckwalsh
Copy link
Contributor Author

ckwalsh commented Nov 6, 2025

Ping @LegacyKing

@LegacyKing LegacyKing merged commit f5ef520 into PCGen:master Nov 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants