Skip to content

Add AggregationCondition #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rasmi wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Add AggregationCondition #908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ad7e53f
Initial attempt at AggregateCondition
rasmi Dec 11, 2025
4310873
Clean up AggregationCondition
rasmi Dec 11, 2025
57cb44a
Add tests for AggregationCondition.
rasmi Dec 11, 2025
c2c66d9
Add AggregationCondition support to prompts.
rasmi Jan 7, 2026
5bb5034
Support for AggregationConditions in editor.
rasmi Jan 8, 2026
da85d97
Support AggregationCondition in survey questions.
rasmi Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions frontend/src/components/experiment_builder/structured_prompt_editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import {
SeedStrategy,
ShuffleConfig,
StageContextPromptItem,
StageKind,
TextPromptItem,
} from '@deliberation-lab/utils';

Expand Down Expand Up @@ -54,12 +53,6 @@ export class EditorComponent extends MobxLitElement {
);
}

/** Check if the current stage supports conditions (only private chat, not group chat). */
private supportsConditions(): boolean {
const stage = this.experimentEditor.getStage(this.stageId);
return stage?.kind === StageKind.PRIVATE_CHAT;
}

override render() {
return this.renderPromptPreview();
}
Expand Down Expand Up @@ -213,8 +206,7 @@ export class EditorComponent extends MobxLitElement {
}

const conditionTargets = this.getConditionTargets();
const supportsConditions =
this.supportsConditions() && conditionTargets.length > 0;
const hasConditionTargets = conditionTargets.length > 0;

return items.map((item, index) => {
const hasCondition = item.condition !== undefined;
Expand All @@ -224,7 +216,7 @@ export class EditorComponent extends MobxLitElement {
<div class="prompt-item-row">
<div class="prompt-item-editor">${this.renderItemEditor(item)}</div>
<div class="prompt-item-actions">
${supportsConditions && item.type !== PromptItemType.GROUP
${hasConditionTargets && item.type !== PromptItemType.GROUP
? html`
<pr-icon-button
icon="rule"
Expand Down
80 changes: 80 additions & 0 deletions frontend/src/components/stages/condition_editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,3 +185,83 @@
min-width: 150px;
}
}

.aggregation-condition {
display: flex;
flex-direction: column;
gap: common.$spacing-small;
padding: common.$spacing-small;
background: var(--md-sys-color-secondary-container);
border-radius: 8px;
border: 1px solid var(--md-sys-color-outline-variant);

.aggregation-header {
display: flex;
align-items: center;
gap: common.$spacing-small;
flex-wrap: wrap;

.aggregator-select {
min-width: 180px;
}

.aggregation-label {
@include typescale.body-medium;
color: var(--md-sys-color-on-secondary-container);
white-space: nowrap;
}

.target-select {
flex: 1;
min-width: 200px;
}
}

.filter-comparison {
display: flex;
align-items: center;
gap: common.$spacing-small;
flex-wrap: wrap;
padding: common.$spacing-small;
background: var(--md-sys-color-surface-container);
border-radius: 4px;

.filter-label {
@include typescale.body-small;
color: var(--md-sys-color-on-surface-variant);
white-space: nowrap;
}

.operator-select {
min-width: 150px;
}

.value-input {
min-width: 100px;
max-width: 150px;
}
}

.aggregation-comparison {
display: flex;
align-items: center;
gap: common.$spacing-small;
flex-wrap: wrap;

.comparison-label {
@include typescale.body-medium;
color: var(--md-sys-color-on-secondary-container);
white-space: nowrap;
}

.operator-select {
min-width: 150px;
}

.value-select,
.value-input {
min-width: 100px;
flex: 1;
}
}
}
Loading