Merged
Conversation
Contributor
|
Remind me as I've been out of this code for a while, this is moving the signaling from our UI into FlutterSwiftOCA? Is there a reason this is required or is this just a good refactoring that would be required (rather than optional) in the connection broker branch? |
Contributor
Author
|
Yes, it would serve the same function as the current code does in the three runners (each is setting up a channel for this), so we could remove that. And it would also serve the same purpose for the connection broker branch, so it solves 4 problems in one location. It will co-exist with the current solution, though. |
lhoward
approved these changes
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a suggested change to OcaChannelManager, it adds a callback channel that signals platform_ready at the end of
init, letting Flutter code synchronize stream subscriptions to when native listeners have been set up.This PR is meant for main, but there is currently a similar kind of race in the client-connection-broker-2 branch;
onControlwill create a new OcaChannelManager but the Flutter side currently will not know when it is ready.This PR will work for that case as well, at least until a better solution is available, the only change needed for that case would be to use a channelSuffix for the new platformStateChannel.
See what you think?