Skip to content

fix: position updates not always getting sent#29

Merged
chrisj-er merged 4 commits intomainfrom
release-2026-03-20
Mar 21, 2026
Merged

fix: position updates not always getting sent#29
chrisj-er merged 4 commits intomainfrom
release-2026-03-20

Conversation

@chrisj-er
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to ensure EdgeTech position-only updates are not skipped/rejected due to duplicate (device_id, recorded_at) collisions by switching update recorded_at generation to use the current time, and adjusting tests accordingly.

Changes:

  • Update _create_gear_payload to use datetime.now(timezone.utc) for update recorded_at (when include_initial_deployment=False).
  • Remove the recorded_at de-dup/skip logic in _identify_buoys, based on the assumption that update recorded_at values will now be unique.
  • Update/rename tests to validate the new recorded_at behavior for updates.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
app/actions/edgetech/processor.py Switch update recorded_at generation to “current time” and remove recorded_at-based skip logic in buoy identification.
app/actions/tests/test_edgetech_processor.py Update tests and assertions to reflect “current time” recorded_at for updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chrisj-er chrisj-er merged commit bdbdd51 into main Mar 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants