fix: position updates not always getting sent#29
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure EdgeTech position-only updates are not skipped/rejected due to duplicate (device_id, recorded_at) collisions by switching update recorded_at generation to use the current time, and adjusting tests accordingly.
Changes:
- Update
_create_gear_payloadto usedatetime.now(timezone.utc)for updaterecorded_at(wheninclude_initial_deployment=False). - Remove the recorded_at de-dup/skip logic in
_identify_buoys, based on the assumption that update recorded_at values will now be unique. - Update/rename tests to validate the new recorded_at behavior for updates.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
app/actions/edgetech/processor.py |
Switch update recorded_at generation to “current time” and remove recorded_at-based skip logic in buoy identification. |
app/actions/tests/test_edgetech_processor.py |
Update tests and assertions to reflect “current time” recorded_at for updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.