get both gearset devices from ER, so we can compare them with the inc…#28
get both gearset devices from ER, so we can compare them with the inc…#28
Conversation
…oming edgetech gearset updates.
There was a problem hiding this comment.
Pull request overview
This PR updates the EdgeTech processing flow so that, during update operations for two‑unit lines, the processor can include the end‑unit device details from EarthRanger (ER) when the end unit is not present in the current EdgeTech sync window—enabling proper comparison/updates against incoming EdgeTech gearset updates.
Changes:
- Extend
_create_gear_payloadto optionally build the secondary device from an ERBuoyDevicewhen the end unit buoy isn’t available from EdgeTech. - Update the update-path logic in
process()to fall back to ER’s end-unit device instead of skipping the update. - Add/adjust tests to cover the “end unit not in sync window” update behavior and related formatting/cleanup.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
app/actions/edgetech/processor.py |
Adds ER end-unit fallback for two-unit updates and threads the ER device into payload generation. |
app/actions/tests/test_edgetech_processor.py |
Adds a targeted regression test for the ER end-unit fallback and applies minor cleanup/formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…e end device, we get what's currently stored in ER.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…but in reverse order.
… minute, consider this a new deployment of the serialNumber. And conclude we never received the haul for that serial number.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
… now look through the change logs to find that and update Buoy appropriately
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…oming edgetech gearset updates.