feature: add a flag for recording extra activity logs.#9
Merged
chrisdoehring merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to documentation, configuration, and logging behavior for the Ctrack Crystal integration. The main changes include adding a comprehensive guide for developers, enhancing configuration options for the pull observations action, and refining logging logic to provide more control over activity records.
Documentation and Developer Guidance:
CLAUDE.mdfile that explains project architecture, commands for development and testing, and conventions for working with the codebase. This guide is intended to help developers (including AI assistants) understand and contribute to the repository more effectively.Configuration Enhancements:
AuthenticateConfigandPullObservationsConfigclasses inapp/actions/configurations.pyto clarify their purpose and usage. [1] [2]log_all_vehicle_activity, toPullObservationsConfig. This option allows users to control whether activity records are logged for every vehicle, even when no new observations are found.Logging Behavior Improvements:
app/actions/handlers.pyto respect the newlog_all_vehicle_activityconfiguration. Now, activity is logged for all vehicles only if this option is enabled, otherwise only when new observations are present.