Skip to content

Sync fork#6

Merged
chrisdoehring merged 14 commits intomainfrom
main
Mar 3, 2026
Merged

Sync fork#6
chrisdoehring merged 14 commits intomainfrom
main

Conversation

@chrisdoehring
Copy link
Copy Markdown

This pull request enhances the configuration management logic for integrations, adding full support for webhook configurations alongside existing action configurations. It also improves cache handling by supporting TTL (time-to-live) for cached items and strengthens error handling and test coverage. Additionally, it updates retry strategies for Gundi service calls to be more robust.

Configuration Management Enhancements:

  • Added support for storing and retrieving WebhookConfiguration in IntegrationConfigurationManager, including new methods for handling webhook config keys and values in Redis. [1] [2]
  • Updated all cache-related methods (set, get, etc.) to accept an optional TTL parameter, allowing control over cache expiration for integrations, action configs, and webhook configs. [1] [2]

Testing Improvements:

  • Introduced new pytest fixtures in app/conftest.py for mocking Redis and Gundi client behavior specifically for webhook configuration scenarios and error simulation, improving test coverage for webhook and cache-miss cases. [1] [2]

Retry Logic Updates:

  • Increased initial wait and maximum retry times for all Gundi service API calls using stamina.retry, making retries more resilient to transient failures. [1] [2] [3] [4] [5]

Code Consistency and Minor Fixes:

  • Renamed internal methods for key generation to clarify their purpose (e.g., _get_integration_config_key to _get_action_config_key).
  • Updated imports to include WebhookConfiguration where needed. [1] [2]

Test Adjustments:

  • Modified integration set test to expect TTL parameter, ensuring correct behavior for non-expiring cache entries.

@chrisdoehring chrisdoehring merged commit 934fab0 into PADAS:main Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants