Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
GUNDI-4722: Webhook support improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the configuration management logic for integrations, adding full support for webhook configurations alongside existing action configurations. It also improves cache handling by supporting TTL (time-to-live) for cached items and strengthens error handling and test coverage. Additionally, it updates retry strategies for Gundi service calls to be more robust.
Configuration Management Enhancements:
WebhookConfigurationinIntegrationConfigurationManager, including new methods for handling webhook config keys and values in Redis. [1] [2]set,get, etc.) to accept an optional TTL parameter, allowing control over cache expiration for integrations, action configs, and webhook configs. [1] [2]Testing Improvements:
app/conftest.pyfor mocking Redis and Gundi client behavior specifically for webhook configuration scenarios and error simulation, improving test coverage for webhook and cache-miss cases. [1] [2]Retry Logic Updates:
stamina.retry, making retries more resilient to transient failures. [1] [2] [3] [4] [5]Code Consistency and Minor Fixes:
_get_integration_config_keyto_get_action_config_key).WebhookConfigurationwhere needed. [1] [2]Test Adjustments: