chore: canonical async _delete and 204 handling in _call#45
Merged
JoshuaVulcan merged 1 commit intomainfrom Feb 11, 2026
Merged
chore: canonical async _delete and 204 handling in _call#45JoshuaVulcan merged 1 commit intomainfrom
JoshuaVulcan merged 1 commit intomainfrom
Conversation
- async _delete(path, params=None, base_url=None) delegates to _call - _call treats 204 No Content as success and returns True (no JSON parse) - Optional base_url in _call for versioned endpoints (e.g. v2 event types) - Unifies six independent PR implementations (PRs 28,30,32,34,36,41) Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
@JoshuaVulcan We're conflicting on these now, since this got merged in front of mine (#23) I'lll protections on the main branch to catch these in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unifies six independent
async _delete()implementations across PRs 28, 30, 32, 34, 36, 41.Canonical (PR #36 style):
async def _delete(self, path, params=None, base_url=None)— delegates to_call_call: on 204 No Content returnsTrue(no JSON parse)base_urlin_call/_deletefor versioned endpoints (e.g. v2 event types in PR 30)Merge this PR first, then the feature PRs (already rebased onto this branch) can be merged in any order.
Related: ERA-12650 (28), ERA-12656 (30), ERA-12662 (32), ERA-12666 (34), ERA-12674 (36), ERA-12682 (41).