Refactor: Introduce Configuration class for type-safe config handling #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors configuration handling in the
code-base-investigatorproject by introducing type-safe, structured configuration objects.Motivation
Previously, the
configurationobject was passed as a loosely typeddict[Any, list[dict[str, Any]]], marked with aFIXMEinfinder.py. This resulted in:Changes Introduced
codebasin/config.pyPreprocessorConfiguration(Modified): Added afile: strattribute for explicit file association.Configuration(New dataclass): A type-safe container forlist[PreprocessorConfiguration], representing a platform’s configuration.ArgumentParser.parse_args()(Modified): Updated to accept afilename: strargument.load_database()(Refactored): Now constructs and returns aConfigurationobject.codebasin/__main__.py&codebasin/tree.pyConfigurationobjects.codebasin/finder.pyfind()function signature and internal logic to usedict[str, Configuration]and access data via well-defined attributes.FIXMEcomment related to configuration complexity.Tests (
tests/**/*.py)ConfigurationandPreprocessorConfigurationdataclasses.tests/compilers/test_compilers.pyto pass thefilenameargument.self.expected_setmapintests/include/test_include.pyto reflect accurate calculation results.Verification
All unit tests pass, confirming that existing external behavior is preserved while significantly improving internal code quality.