Skip to content

Exclude LAG member ports from excessive tagged VLANs audit#280

Merged
tvancott42 merged 1 commit intomainfrom
bugfix/lag-audit
Feb 15, 2026
Merged

Exclude LAG member ports from excessive tagged VLANs audit#280
tvancott42 merged 1 commit intomainfrom
bugfix/lag-audit

Conversation

@tvancott42
Copy link
Collaborator

@tvancott42 tvancott42 commented Feb 15, 2026

Summary

  • LAG child ports no longer trigger false positive "Excessive Tagged VLANs" issues. LAG member ports have a raw forward: "all" config that is irrelevant since they're assimilated into the parent LAG port. Ports with both lag_idx (number) and aggregated_by (number) are now marked as IsLagChild and skipped by most audit rules.
  • Unused port detection still applies to LAG child ports. Rules can opt in to evaluate LAG children via AppliesToLagChildPorts. Currently only UnusedPortRule opts in, so disconnected LAG member ports are still flagged if not disabled.

Closes #206

Test plan

  • 10 new tests covering LAG detection, parent vs child, multiple members, missing fields, and integration with both AccessPortVlanRule (excluded) and UnusedPortRule (included)
  • All 5,138 existing tests pass, 0 build warnings
  • Run audit on NAS deployment and verify LAG ports no longer generate excessive VLAN issues

LAG member ports that are aggregated into a parent port have a raw
forward="all" config that is irrelevant since they are assimilated.
Mark ports with both lag_idx and aggregated_by as numbers as IsLagChild,
and skip them for all audit rules except those that opt in via
AppliesToLagChildPorts (currently only UnusedPortRule).
@tvancott42 tvancott42 merged commit 86390cf into main Feb 15, 2026
1 check passed
@tvancott42 tvancott42 deleted the bugfix/lag-audit branch February 15, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exclude LAG member ports from excessive tagged VLANs audit

1 participant