Skip to content

Allow NVRs on Management VLAN in security audit#271

Merged
tvancott42 merged 1 commit intomainfrom
bugfix/unvr-audit-classification
Feb 14, 2026
Merged

Allow NVRs on Management VLAN in security audit#271
tvancott42 merged 1 commit intomainfrom
bugfix/unvr-audit-classification

Conversation

@tvancott42
Copy link
Collaborator

@tvancott42 tvancott42 commented Feb 14, 2026

Summary

  • NVRs (UNVR, UNVR-Pro, Cloud Key) are now accepted on Management or Security VLANs - previously all Protect devices were classified as cameras and flagged Critical if not on the Security VLAN, causing false positives for dual-homed NVRs
  • NVR-specific issue title and recommendation - when an NVR is on the wrong VLAN, the audit shows "NVR on Wrong VLAN" and recommends both Management and Security VLANs as valid targets
  • Regular cameras unchanged - cameras (including Protect cameras) are still required to be on the Security VLAN only

Closes #268

Test plan

  • 14 new unit tests covering NVR placement, detection metadata, message format, and regression guards
  • All 4,977 tests pass with 0 warnings
  • Run security audit on NAS - verify existing camera issues unchanged
  • Run security audit on Mac - verify existing camera issues unchanged
  • User with UNVR on Management VLAN confirms false positive is resolved

NVRs (UNVR, UNVR-Pro, Cloud Key) are infrastructure devices that
legitimately belong on Management or Security VLANs. Previously all
Protect devices were classified as cameras and flagged if not on the
Security VLAN, causing false positives for dual-homed NVRs.

Closes #268
@tvancott42 tvancott42 merged commit 7479ec5 into main Feb 14, 2026
1 check passed
@tvancott42 tvancott42 deleted the bugfix/unvr-audit-classification branch February 14, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Treat UniFi Protect consoles with properly isolated cameras the same as other UniFi consoles.

1 participant