Respect csv_start_row when reading header for column index validation
#174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x validation - Add skiprows=csv_start_row to header reading in read() when csv_txyz_idxs is specified - Change skiprows from range(1, csv_start_row + 1) to csv_start_row for consistent semantics - Adjust nrows calculation to match new interpretation (csv_start_row = header row, not first data row) - Update docstrings to clarify csv_start_row means "file row where header is located" Fixes bug where CSV files with metadata rows before header (e.g., ActiGraph exports) would fail with "Column index X out of range" because header was read from row 0 instead of the specified csv_start_row.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where
--csv-start-rowwas not respected when validating column indices via--csv-txyz-idxs. CSV files with metadata rows before the header (e.g., ActiGraph exports) would fail with "Column index X out of range" because the header was always read from row 0.Changes
src/stepcount/utils.py
skiprows=csv_start_rowwhen reading header for column index validationrange(1, csv_start_row + 1)tocsv_start_rowfor consistent semanticscsv_start_rownow clearly means "file row where header is located (0-indexed)"Test