MYASM2 - Prepare #3
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
for unit tests : maybe use Unity ? It has a reputation to just work |
Overengined
reviewed
Dec 3, 2025
| long long int len = strlen(content); | ||
| if (verbose == true) { | ||
|
|
||
| if (verbose) { |
Owner
There was a problem hiding this comment.
if (verbose) is not the same as if (verbose)==true since if (<varname>) checks if is nonzero. since we have varbose as a std boolean, this won't work. We could always take teh other approach and change verbose to an int to use ore standard (0 or 1) C logic
Overengined
requested changes
Dec 3, 2025
Owner
Overengined
left a comment
Overengined
left a comment
There was a problem hiding this comment.
should fix the error with verbose by either changing verbose to an int or using boolean logic
Author
|
Ok good to know, we'll use an int logic to enable verbosity level. It's gonna be useful for debugging. |
Owner
|
Yes, it should not be overly complicated. Feel free to open an issue on the matter. I know I will, sooner or later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the Prepare function. Before merging it, please make sure the following check list is done :