fix: Only show error page if main page fails #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OS-pedrogustavobilro
requested review from
ItsChaceD,
OS-ruimoreiramendes,
andredestro,
capacitor-bot and
markemer
and removed request for
a team
To fix CI error in matching bundler version with fastlane
To fix CI error in matching bundler version with fastlane
alexgerardojacinto
approved these changes
Jan 15, 2026
7 tasks
OS-pedrogustavobilro
added a commit
to ionic-team/capacitor-os-inappbrowser
that referenced
this pull request
Jan 15, 2026
…unresolvable Via native library update OutSystems/OSInAppBrowserLib-Android#53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The WebView client's onReceivedError is called for errors in loading the main page and also any sub-resources it may have.
Currently if one of those sub-resources fails to load because it has an unresolvable domain, the library show's an error screen, even though the actual page can load successfully.
The fix involves only showing an error screen if the error received is for the main page, using isForMainFrame property. That way, if the main page is unresolvable (e.g. no network connection), we show an error.
Context
https://outsystemsrd.atlassian.net/browse/RMET-4937
Type of changes
Tests
Refer to JIRA ticket above for reproduction info.
See this older MABS build with issue vs this MABS build with the fix