-
Notifications
You must be signed in to change notification settings - Fork 4
feat(android): allow for photo and video capturing and filter for media type for file uploads (onShowFileChooser)
#52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alexgerardojacinto
merged 24 commits into
main
from
feat/RMET-4466/webview-take-photo-video-gallery
Sep 8, 2025
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
33e99a8
test: add unit tests for OSIABPdfHelper
andredestro 4b6aa0a
test: first version of an implementation to allow upload of photos or…
alexgerardojacinto a0a6c2f
Merge branch 'main' into feat/twebview-take-photo-video-gallery
alexgerardojacinto 1d2e68e
feat: use fileChooseParams to determine if user should be able to tak…
alexgerardojacinto 0cc3f4a
feat: implement requesting the permission for the camera if needed
alexgerardojacinto dcfca2d
feat: if permission to the camera is denied, we should still present …
alexgerardojacinto 5f43881
feat: when `capture` is passed, only give camera options, otherwise, …
alexgerardojacinto 935f7e6
chore: small refactors
alexgerardojacinto 48d5119
fix: remove unnecessary URI permission grants
alexgerardojacinto b04eb84
refactor: multiple refactors to make the code more readable and cleaner
alexgerardojacinto c74b4bb
chore: refactor comments
alexgerardojacinto 0bb0486
fix: some devices (e.g. Samsung) don't return video in results.data, …
alexgerardojacinto a590bb4
chore: refactor comment placement
alexgerardojacinto ddbfa34
chore: update changelog
alexgerardojacinto aa8715f
chore: remove extra lines
alexgerardojacinto c0b3194
chore: add comment explaining usage of FileProvider
alexgerardojacinto 8ba9fd8
chore: update lib version to 1.6.0
alexgerardojacinto a62b048
Merge remote-tracking branch 'origin/feat/twebview-take-photo-video-g…
alexgerardojacinto af05759
refactor: remove unnecessary if/else
alexgerardojacinto c3251dc
feat: only request camera permission if it is declared in AndroidMani…
alexgerardojacinto 0a05230
refactor: use more human readable format for file names
alexgerardojacinto c1f6a4b
refactor: no need to duplicate variables
alexgerardojacinto aaa3d41
refactor: remove unnecessary comments
alexgerardojacinto 6516ba5
refactor: split launchFileChooser in multiple functions for readability
alexgerardojacinto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
src/main/java/com.outsystems.plugins.inappbrowser/osinappbrowserlib/FileProvider.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| package com.outsystems.plugins.inappbrowser.osinappbrowserlib | ||
|
|
||
| class FileProvider: androidx.core.content.FileProvider() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <paths> | ||
| <cache-path name="camera" path="." /> | ||
| </paths> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.