-
Notifications
You must be signed in to change notification settings - Fork 4
RMET-2053 :: Add Support for PDF #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
|
The Gradle task |
06468c1 to
84abad4
Compare
...ain/java/com.outsystems.plugins.inappbrowser/osinappbrowserlib/views/OSIABWebViewActivity.kt
Outdated
Show resolved
Hide resolved
|
Note: I don't think we need to do it now, but we could possibly add unit tests for the helper methods you created ( |
|
Results from testing in Pixel 7 and Pixel 9 Pro Android 16 devices:
|
535074a to
33e99a8
Compare
...ain/java/com.outsystems.plugins.inappbrowser/osinappbrowserlib/views/OSIABWebViewActivity.kt
Outdated
Show resolved
Hide resolved
33e99a8 to
ecffb88
Compare
|
Results of second test: I think the |
Description
This PR adds support for PDF files in the WebView on Android via PDF.js.
Context
https://outsystemsrd.atlassian.net/browse/RMET-2053
Type of changes
Platforms affected
Tests
apk.zip
Screenshots (if appropriate)
Checklist
RNMT-XXXX <title>