-
Notifications
You must be signed in to change notification settings - Fork 1
fix parsing and extraction of time-zone aware datetime between logs and db #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mishaschwartz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense. Thanks for updating that.
Since this just parses the logs from the proxy component. Do we ever have a case where the proxy logs aren't generating TZ-aware timestamps?
Yes. I think it is possible for historical reasons, or when the produced entry by the service itself is not fully explicit about its timezone. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 80.76% 83.91% +3.14%
==========================================
Files 11 11
Lines 572 578 +6
Branches 63 64 +1
==========================================
+ Hits 462 485 +23
+ Misses 80 64 -16
+ Partials 30 29 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
## Overview Update `CanarieAPI==1.0.3` default version. ## Changes **Non-breaking changes** - Canarie-API: Update to [`1.0.3`](https://github.com/Ouranosinc/CanarieAPI/releases/tag/1.0.3) to fix log parsing. - Ensure that timezone-aware date-time are considered. - Fix statistics retrieval to obtain service/request invocation counts. **Breaking changes** - n/a ## Related Issue / Discussion - Relates to Ouranosinc/CanarieAPI#53 - Relates to Ouranosinc/CanarieAPI#21). ## CI Operations birdhouse_daccs_configs_branch: master birdhouse_skip_ci: false
Changes
ReadTimeoutnot handled asConnectionErrorduring service check.Related