You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is it okay to add the dependency on compojure or would you rather see an implementation without an additional dep?
I would rather have a morse-compojure module, which can have compojure-specific handlers ;)
If you go down that road, I promise to port everything to pedestal even ;)
What would make sense to return from the direct-reply handler?
I think it makes sense, should be enough for Telegram
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I redid the PR in its own branch.
A couple of things I need some opinion/guidance on:
direct-replyhandler? I'm not sure about{:status 200}As for the tests, I've never written those. Interested to learn though, but that will take me a bit. It's probably not correct on the first try.