test: improve darksky.py test coverage from 53% to 100%#3
Merged
Conversation
Add comprehensive tests covering all previously uncovered areas: - TwilightType.sun_angle_range property for all types - DarkSkyWindow.time_until_darkness() all code paths - DarkSkyWindow.time_remaining() all code paths - DarkSkyWindow.__str__() edge cases (no data, no darkness reason) - DarkSkyWindow.is_currently_dark() with naive datetimes - get_twilight_type() function for all angle ranges - get_dark_sky_window() polar/non-polar edge cases - DarkSkyClient async wrapper methods - Naive datetime UTC conversion paths 54 tests total, all passing. Coverage: 53% → 100%. Closes #1
Add comprehensive tests covering all previously uncovered areas: - TwilightType.sun_angle_range property - DarkSkyWindow.time_until_darkness() - all paths - DarkSkyWindow.time_remaining() - all paths - DarkSkyWindow.__str__() edge cases - get_twilight_type() function - DarkSkyClient async wrapper methods - Non-polar latitude with missing twilight data - Naive datetime handling Closes #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive tests for the darksky.py module, improving coverage from 53% to 100%.
What's covered now
TwilightType.sun_angle_rangeproperty for all typesDarkSkyWindow.time_until_darkness()— all code paths (None, before, after, naive datetime)DarkSkyWindow.time_remaining()— all code paths (None, after, during, before, naive datetime)DarkSkyWindow.__str__()— no darkness reason, no data, fractional hoursDarkSkyWindow.is_currently_dark()— no data, naive datetimeget_twilight_type()— all angle ranges and boundariesget_dark_sky_window()— polar summer/winter, non-polar missing data, best viewing time, moon timesDarkSkyClient— all async wrapper methods including close()is_astronomical_darkness()Stats
Closes #1