fix: remove non-existent BASS_Free import from sound_lib#3
Closed
fix: remove non-existent BASS_Free import from sound_lib#3
Conversation
Fixes #2 The BASS_Free symbol doesn't exist in sound_lib.main. The previous import caused an ImportError that prevented all tests from running. Changes: - Remove unused sound_lib.main import (BassError, bass_call_0, BASS_Free) - Remove BASS_Free() call in cleanup() - sound_lib handles cleanup automatically when the Output object is garbage collected
Owner
Author
|
The BASS_Free import fix in PR #4 targeted the old directory structure. The current codebase still has it — will fix separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2
The
BASS_Freesymbol doesn't exist insound_lib.main. This caused anImportErrorthat prevented all tests from even collecting.Changes
sound_lib.mainimport (BassError,bass_call_0,BASS_Free)BASS_Free()call incleanup()- sound_lib handles cleanup automatically when theOutputobject is garbage collectedTesting