Open
Conversation
added 3 commits
February 20, 2021 18:14
MoonChel
force-pushed
the
vlado/pyparsing
branch
from
ed66e34 to
3865f2b
Compare
MoonChel
force-pushed
the
vlado/pyparsing
branch
from
af39370 to
d116407
Compare
| @@ -1,13 +1,18 @@ | |||
| import re | |||
| from pyparsing import * | |||
Owner
There was a problem hiding this comment.
Can we get rid from such types' of imports please? Import just what you need in code and nothing else.
I see at least one big disadvantage in here: you're importing everything from pyparsing namespace to current one, but you can not say what exactly were imported, so there is place for overriding some methods/variables/classes that were imported from there.
Also, as far as I remember, some code analysing tools could fail because of this imports (skip them, fail on them, etc.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.