Skip to content

telemetry with batching, persistence, and improved logging #4014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Niks988 wants to merge 5 commits into
base: v8/develop
Choose a base branch
from
Open

telemetry with batching, persistence, and improved logging #4014

Niks988 wants to merge 5 commits into from

Conversation

@Niks988
Copy link
Collaborator

@Niks988 Niks988 commented Jul 25, 2025

Description

  • Add event batching (50 events, 5s timeout) for better performance
  • Implement persistent queue (10K events) to prevent event loss during QuestDB downtime
  • Add connection health monitoring and auto-reconnection
  • Improve logging with clear batch and queue status
  • Add graceful shutdown with event flushing
  • Eliminate ECONNRESET spam with error rate limiting
  • Add fallback mechanisms and memory leak protection

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

Mihajlo-Pavlovic
Mihajlo-Pavlovic requested changes Jul 30, 2025
View reviewed changes
@Mihajlo-Pavlovic
Copy link
Collaborator

Mihajlo-Pavlovic commented Jul 30, 2025

Did partial review, can you address these comments, also address claued raised issues and liter errors

swamala added a commit that referenced this pull request Oct 29, 2025
@swamala
fix: address PR review comments
ac685e5 
   - Remove signal handler duplication to prevent shutdown race conditions
   - Fix telemetry cleanup method access path
   - Extract magic values to constants for better maintainability
   - Limit proof event logging to prevent huge logs
   - Refactor sequential retry to parallel for better performance
   - Fix queue status log consistency
   - Remove dead code (logLifetimeProofSummary)

   Addresses review comments from PR #4014
cursor[bot]

This comment was marked as outdated.

Sign in to view

swamala added a commit that referenced this pull request Oct 29, 2025
@swamala
fix: address PR review comments
dcf8f85 
   - Remove signal handler duplication to prevent shutdown race conditions
   - Fix telemetry cleanup method access path
   - Extract magic values to constants for better maintainability
   - Limit proof event logging to prevent huge logs
   - Refactor sequential retry to parallel for better performance
   - Fix queue status log consistency
   - Remove dead code (logLifetimeProofSummary)

   Addresses review comments from PR #4014
@swamala swamala force-pushed the improvements/telemetry-upgrades branch from ac685e5 to dcf8f85 Compare October 29, 2025 12:45
cursor[bot]

This comment was marked as outdated.

Sign in to view

swamala added a commit that referenced this pull request Oct 29, 2025
@swamala
fix: address PR review comments
adb895b 
   - Remove signal handler duplication to prevent shutdown race conditions
   - Fix telemetry cleanup method access path
   - Extract magic values to constants for better maintainability
   - Limit proof event logging to prevent huge logs
   - Refactor sequential retry to parallel for better performance
   - Fix queue status log consistency
   - Remove dead code (logLifetimeProofSummary)

   Addresses review comments from PR #4014
@swamala swamala force-pushed the improvements/telemetry-upgrades branch from dcf8f85 to adb895b Compare October 29, 2025 13:56
cursor[bot]

This comment was marked as outdated.

Sign in to view

@swamala
fix: address PR review comments
fe97c68 
   - Remove signal handler duplication to prevent shutdown race conditions
   - Fix telemetry cleanup method access path
   - Extract magic values to constants for better maintainability
   - Limit proof event logging to prevent huge logs
   - Refactor sequential retry to parallel for better performance
   - Fix queue status log consistency
   - Remove dead code (logLifetimeProofSummary)

   Addresses review comments from PR #4014
@swamala swamala force-pushed the improvements/telemetry-upgrades branch from adb895b to fe97c68 Compare October 29, 2025 14:50
cursor[bot]

This comment was marked as outdated.

Sign in to view

@swamala swamala requested a review from zsculac November 5, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@branarakic branarakic Awaiting requested review from branarakic branarakic is a code owner

@Mihajlo-Pavlovic Mihajlo-Pavlovic Awaiting requested review from Mihajlo-Pavlovic Mihajlo-Pavlovic is a code owner

@zsculac zsculac Awaiting requested review from zsculac

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Niks988 @Mihajlo-Pavlovic @swamala