v8.1.1-rc.7 Testnet Prerelease #4003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v8.1.0 Mainnet Prerelease
…ing-service remove hotfix
v8.1.1+rc.1 Testnet Release
v8.1.1-rc.2 Mainnet Prerelease
v8.1.1-rc.4 Testnet Release
refactor: decouple intervals for sync new and sync missed KCs
Enable claiming for mainnet
8.1.1-rc.4 Mainnet Prerelase
v8.1.1-rc.5 Testnet Release
v8.1.1-rc.5 Mainnet Prerelease
…get-telemetry Improvment/better proofing get telemetry
feat: implement early settling threshold for batchGet
…ved-message Add early finish for batchGet command
…g-service Simplify proofing service
Fix/wrong delete query
…nd-new-sync refactor: decouple missed and new sync
…-timeout BatchGet message timeout
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: Race Conditions in BatchGetCommand
Two race conditions exist in BatchGetCommand due to concurrent processing of messagePromises:
- Concurrent modification of
ualNotPresentLocallycan lead to incorrect element removal when overlapping UALs are returned, asindexOfandsplicecalls become desynchronized. - Multiple operations can simultaneously satisfy
hasReachedThreshold()and calloperationService.markOperationAsCompletedbeforecommandCompletedis set, resulting in duplicate completion handling.
src/commands/protocols/get/sender/batch-get-command.js#L301-L321
Was this report helpful? Give feedback by reacting with 👍 or 👎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.