Skip to content

feat(application): reword deny message #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PadBro merged 1 commit into from
Jan 1, 2026
Merged

feat(application): reword deny message #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/Repositories/ApplicationSubmissionRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public function updateApplicationSubmission(ApplicationSubmission $applicationSu
ApplicationSubmissionState::Denied => 'denied',
default => 'handled',
};
$responseSent = $this->sendResponseToUser($applicationSubmission, $action);
$responseSent = $this->sendResponseToUser($applicationSubmission);
$roleResult = $this->handleRoles($applicationSubmission);

$message = "<@{$applicationSubmission->handled_by}> {$action} <@{$applicationSubmission->discord_id}>\`s application for: `{$applicationSubmission->application?->name}`";
Expand Down Expand Up @@ -284,8 +284,13 @@ private function getButtonsActionRow(ApplicationSubmission $applicationSubmissio
return new ActionRowData(components: $buttons);
}

private function sendResponseToUser(ApplicationSubmission $applicationSubmission, string $action): bool
private function sendResponseToUser(ApplicationSubmission $applicationSubmission): bool
{
$action = match ($applicationSubmission->state) {
ApplicationSubmissionState::Accepted => 'accepted',
default => 'reviewed',
};

if ($applicationSubmission->applicationResponse) {
$message = $applicationSubmission->applicationResponse->response;
} elseif ($applicationSubmission->custom_response) {
Expand Down