ci: update migration command in CI workflow and package.json#3
Merged
ci: update migration command in CI workflow and package.json#3
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request aligns the CI database setup workflow with the project's established push-based schema deployment strategy. Instead of running migration files, the CI workflow now directly pushes the schema to the test database, matching the pattern used in the regular db:migrate command.
Changes:
- Replaced
db:migrate:ciscript (which useddrizzle-kit migrate) withdb:push:ci(which usesdrizzle-kit push --force) - Updated CI workflow to call the new
db:push:ciscript
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/db/package.json | Replaces the db:migrate:ci script with db:push:ci using drizzle-kit push --force for CI environments |
| .github/workflows/ci.yml | Updates the migration step to use the new db:push:ci script instead of db:migrate:ci |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:62
- The step name "Run migrations" is now misleading since the command has been changed from running migrations to force-pushing the schema. Consider updating the step name to better reflect what it does, such as "Push database schema" or "Initialize database schema".
- name: Run migrations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the database migration workflow for continuous integration (CI) to use a direct schema push instead of running migrations. The main goal is to ensure the database schema in CI always matches the current codebase, avoiding issues with migration history.
CI Workflow Updates:
.github/workflows/ci.ymlto use the newdb:push:ciscript, which force-pushes the schema to the database instead of running migrations.Database Script Changes:
packages/db/package.jsonto replace thedb:migrate:ciscript (which randrizzle-kit migrate) withdb:push:ci, which runsdrizzle-kit push --forceto overwrite the schema in CI environments.