[WIP] Homebrew options improvements#497
Draft
MeanderingCode wants to merge 2 commits intoOrcpub:developfrom
Draft
[WIP] Homebrew options improvements#497MeanderingCode wants to merge 2 commits intoOrcpub:developfrom
MeanderingCode wants to merge 2 commits intoOrcpub:developfrom
Conversation
|
https://github.com/Orcpub/orcpub/pull/497/checks?check_run_id=1579168521 Need to move |
Author
Thanks, @datdamnzotz. For some reason, I am able to see the section in the view just fine, anyway. But either way, it does not apply the spells in the Feat to my character, they way the same options in the Subrace Builder do. Also, any idea why the Weapon Proficiency I added to the Background Builder similarly doesn't apply? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description:
This PR is a WIP for the items listed below. Currently, the options appear on the builder pages and save to the homebrew object, but do not appear to be read correctly in the character builder / viewers. If someone with more familiarity can point me in the right direction (data model issues, something new not added to a reader / renderer?), it would expedite me finishing this. Otherwise, I will poke around more when I have time.
Adds some simple features and changes to some homebrew builder types:
Related issue (if applicable):
Addresses #50 (not complete)
Addresses #172 (comment)
Checklist: