Assorted screensaver.js bug fixes.#172
Open
Gollimnar wants to merge 1 commit intoOrangeJedi:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #171 -
Setting video.src = "" or video.src = null causes an error event, at least in the edge engine (chromium?). Setting it to video.removeAttribute( "src" ) has the correct result.
The error events in "pre-player" would fail to log the reason for the error properly.
prepVideo() didn't handle failure to find the video by ID properly - the workaround just logs this and lets it skip to another video instead of a dereferencing a null value.
The fade/down and wipe/down transitions should have read 'bottom' instead to match the transition code. They triggered a null dereference exception as a result.
Any errors inside drawVideo() - like transitions - result in drawVideo() not being queued up again for the next animation frame, freezing the screensaver.
The 'blankTheScreen' message repeats and would cause a slow strobe effect as the fadeout effect would trigger each time.
Note that two outstanding screensaver bugs still seem to exist and aren't fixed by this. In each case they were only observed once and I couldn't duplicate them:
Leaving the screensaver running for extended periods, I can no longer trigger any further bugs.