-
Notifications
You must be signed in to change notification settings - Fork 11
Add linked station #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add linked station #481
Conversation
Signed-off-by: Frédéric Gardes <frederic.gardes@orange.com>
Signed-off-by: Frédéric Gardes <frederic.gardes@orange.com>
Signed-off-by: Frédéric Gardes <frederic.gardes@orange.com>
schema/cam/cam_schema_2-3-1.json
Outdated
| "version": { | ||
| "type": "string", | ||
| "description": "JSON message format version.", | ||
| "const": "2.3.1-dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a minor, backward compatible evolution, so the minor version should be updated, not the patchlevel, so it should be 2.4.0.
| "const": "2.3.1-dev" | ||
| }, | ||
| "linked_station_id": { | ||
| "type": "integer", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better is that were an array rather than a single object. Indeed, there are tractors that may have two (or more!) trailers; for example

Also, for platooning, there might be a bunch of following trucks, so the head of the platoon would need to link to all the trucks that follows it (and individual trucks may also want to link to their own followers.
Do we also want to identify the type of link: following or leading?
{
"linked_station_ids": {
"type": "array",
"description": "list of following or leading stations IDs",
"minItems": 1,
"items": {
"type": "object",
"description": "Linked station",
"required": ["station_id"],
"properties": {
"station_id": {
"type": "integer",
"description": "Identifier for a linked ITS-S, as a trailer or a platooning pair.",
"minimum": 0,
"maximum": 4294967295,
"examples": [
4294967295,
42
]
},
"relation": {
"type": "string",
"description": "how the linked station relates to this one",
"enum": [
"trailer",
"tractor",
"platoon"
]
},
"order": {
"type": "string",
"description": "whether the linked station trails or leads this one",
"enum": [
"trails",
"leads",
]
}
}
}
}
}
ymorin-orange
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- change the version to 2.4.0
- maybe extend the schema to allow for more flexibility in the relationship description, as suggested in the comment
No test, we provide a new optional field linked station id.