Skip to content

Remove GeckoView and Chrome Custom Tabs engines, retain WebView only#2

Merged
xingguangcuican6666 merged 4 commits intomasterfrom
copilot/remove-unused-engines-except-webview
Dec 9, 2025
Merged

Remove GeckoView and Chrome Custom Tabs engines, retain WebView only#2
xingguangcuican6666 merged 4 commits intomasterfrom
copilot/remove-unused-engines-except-webview

Conversation

Copy link

Copilot AI commented Dec 9, 2025

Removes all browser engine implementations except WebView to simplify the codebase.

Files Deleted

  • GeckoViewActivity.java - Firefox/GeckoView engine (403 lines)
  • ChromeTabActivity.java - Chrome Custom Tabs implementation (70 lines)

Dependencies Removed

  • androidx.browser:browser:1.7.0
  • org.mozilla.geckoview:geckoview:143.0.20250929153833
  • Mozilla Maven repository

MainActivity Changes

  • Removed multi-engine UI selection (RadioGroup with 3 options → single WebView option)
  • Removed browserMode parameter from createShortcut() and fetchFaviconAndCreateShortcut()
  • Eliminated switch-case logic for engine selection
// Before: Multiple engine support
switch (browserMode) {
    case 1: intent = new Intent(this, ChromeTabActivity.class); break;
    case 3: intent = new Intent(this, GeckoViewActivity.class); break;
    case 2: intent = new Intent(this, WebViewActivity.class); break;
}

// After: WebView only
Intent intent = new Intent(this, WebViewActivity.class)
    .setAction(Intent.ACTION_VIEW)
    .setData(Uri.parse(url + "#desktopMode=true"));

Retained

  • WebViewActivity (primary browser)
  • DownloadActivity
  • FIDO2 dependency for WebAuthn support

Net Change: -576 lines across 5 files

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED -XX:MaxMetaspaceSize=384m -XX:+HeapDumpOnOutOfMemoryError -Xms256m -Xmx512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.9-bin/90cnw93cvbtalezasaz0blq0a/gradle-8.9/lib/gradle-daemon-main-8.9.jar (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

移除除webview以外的所有无用的引擎


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 3 commits December 9, 2025 07:19
Co-authored-by: xingguangcuican6666 <119158495+xingguangcuican6666@users.noreply.github.com>
Co-authored-by: xingguangcuican6666 <119158495+xingguangcuican6666@users.noreply.github.com>
Co-authored-by: xingguangcuican6666 <119158495+xingguangcuican6666@users.noreply.github.com>
@xingguangcuican6666 xingguangcuican6666 marked this pull request as ready for review December 9, 2025 07:27
Copilot AI review requested due to automatic review settings December 9, 2025 07:27
Copilot AI changed the title [WIP] Remove all unused engines except webview Remove GeckoView and Chrome Custom Tabs engines, retain WebView only Dec 9, 2025
@xingguangcuican6666 xingguangcuican6666 merged commit ee02fb9 into master Dec 9, 2025
8 checks passed
Copilot AI review requested due to automatic review settings March 23, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants