-
Notifications
You must be signed in to change notification settings - Fork 1
Rework Optable API configuration and request forming #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ValentinPostindustria
wants to merge
22
commits into
master
Choose a base branch
from
feature/server_api_v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
094ad40
feat: migrate to using REST API v2
ValentinPostindustria 8d6e1de
fix: unit tests
ValentinPostindustria 7efd435
feat: new unique suffix
ValentinPostindustria dc6b91f
feat: use local SDK sources by default
ValentinPostindustria 71fe63a
feat: api key and testing
ValentinPostindustria ad8359b
feat: introduce `OptableConfig`
ValentinPostindustria 5ae14c5
fix: unit tests
ValentinPostindustria ec71ba5
Introduce Optable demo cases with Prebid (#32)
ValentinPostindustria c6381b3
feat: refactor network layer
ValentinPostindustria dd4ad43
feat: introduce callbacks for identify and targeting methods
ValentinPostindustria 63ba731
feat: rewrite demo apps to use callbacks
ValentinPostindustria 674a426
refactor: examples
ValentinPostindustria bbb6638
feat: rewrite network logic
ValentinPostindustria 0ee30b3
feat: introduce OptableIdentifiers
ValentinPostindustria ff2bbcf
feat: Rx LiveData to traditional callbacks
ValentinPostindustria ade2a26
feat: targeting keywords for GAM
ValentinPostindustria fd0300d
feat: refactor demo apps
ValentinPostindustria 07c7ff4
feat: support consents
ValentinPostindustria 8e464dc
refactor: some methods
ValentinPostindustria 3aff74c
docs: rewrite README file
ValentinPostindustria 2b8c7eb
test: consent query params
ValentinPostindustria bf7a416
feat: corrections
ValentinPostindustria File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,7 @@ g*.iml | |
| .gradle | ||
| .idea | ||
| .kotlin | ||
| libs | ||
|
|
||
| local.properties | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 28 additions & 5 deletions
33
DemoApp/DemoAppJava/app/src/main/java/co/optable/demoappjava/MainActivity.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
DemoApp/DemoAppJava/app/src/main/java/co/optable/demoappjava/TheApplication.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package co.optable.demoappjava; | ||
|
|
||
| import android.app.Application; | ||
| import co.optable.android_sdk.OptableConfig; | ||
| import co.optable.android_sdk.OptableSDK; | ||
|
|
||
| public class TheApplication extends Application { | ||
|
|
||
| public static OptableSDK optable; | ||
|
|
||
| @Override | ||
| public void onCreate() { | ||
| super.onCreate(); | ||
|
|
||
| OptableConfig config = new OptableConfig(this, "prebidtest", "js-sdk", "ca.edge.optable.co"); | ||
| optable = new OptableSDK(config); | ||
| } | ||
|
|
||
| } | ||
161 changes: 0 additions & 161 deletions
161
.../DemoAppJava/app/src/main/java/co/optable/demoappjava/ui/GAMBanner/GAMBannerFragment.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if host is obligatory to provide? can it work using with a default
na.edge.optable.cohost?