-
Notifications
You must be signed in to change notification settings - Fork 0
Added deeplink urls to the capability pages #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Greptile SummaryThis PR adds deeplink URLs to capability detail pages (alerts, incidents, services, teams, tickets, deployments) and telemetry panels (logs, metrics), enabling users to navigate directly to external monitoring and ticketing systems. The implementation adds "View [entity]" buttons that appear when a Key changes:
Issues found:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant DetailPage
participant Panel
participant ExternalSystem
Note over User,ExternalSystem: Capability Detail Page Flow
User->>DetailPage: Navigate to /alerts/[id]
DetailPage->>DetailPage: Fetch alert data
alt alert.url exists
DetailPage->>DetailPage: Render "View alert" button
User->>ExternalSystem: Click "View alert" button
ExternalSystem-->>User: Open alert in external system
end
Note over User,ExternalSystem: Panel List Item Flow
User->>Panel: View DeploymentsPanel/TicketsPanel
Panel->>Panel: Fetch list of items
User->>DetailPage: Click list item
DetailPage->>DetailPage: Navigate to /deployments/[id]
Note over User,ExternalSystem: Telemetry Panel Flow
User->>Panel: View LogsPanel/MetricsPanel
Panel->>Panel: Build query parameters
alt User clicks deeplink
User->>ExternalSystem: Navigate to Kibana/Grafana
ExternalSystem-->>User: Open query in external tool
end
alt MetricSeries has URL
Panel->>Panel: Render "View metric" button
User->>ExternalSystem: Click "View metric" button
ExternalSystem-->>User: Open metric in external system
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
11 files reviewed, 3 comments
app/components/LogsPanel.tsx
Outdated
| Reset to Default | ||
| </button> | ||
| )} | ||
| <a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Hardcoded URL to https://kibana.demo.com should be configurable. Consider using an environment variable or settings configuration to make this URL dynamic per deployment.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: app/components/LogsPanel.tsx
Line: 173:173
Comment:
**style:** Hardcoded URL to `https://kibana.demo.com` should be configurable. Consider using an environment variable or settings configuration to make this URL dynamic per deployment.
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.
app/components/MetricsPanel.tsx
Outdated
| Reset to Default | ||
| </button> | ||
| )} | ||
| <a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Hardcoded URL to https://grafana.demo.com should be configurable. Consider using an environment variable or settings configuration to make this URL dynamic per deployment.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: app/components/MetricsPanel.tsx
Line: 201:201
Comment:
**style:** Hardcoded URL to `https://grafana.demo.com` should be configurable. Consider using an environment variable or settings configuration to make this URL dynamic per deployment.
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.| className="inline-flex items-center gap-1 rounded-lg border border-[#8fdede] bg-white px-2 py-1 text-xs font-medium text-[#0f1a1d] transition hover:border-[#55cfd0] hover:text-[#0b1517]" | ||
| > | ||
| <svg className="h-3 w-3" fill="none" viewBox="0 0 24 24" stroke="currentColor"> | ||
| <path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M10 6H6a2 2 0 00-2 2v10a2 2 0 002-2v-4M14 4h6m0 0v6m0-6L10 14" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: Missing a2 2 0 002 2h10 in the SVG path - the path appears incomplete compared to other external link icons in the codebase.
| <path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M10 6H6a2 2 0 00-2 2v10a2 2 0 002-2v-4M14 4h6m0 0v6m0-6L10 14" /> | |
| <path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M10 6H6a2 2 0 00-2 2v10a2 2 0 002 2h10a2 2 0 002-2v-4M14 4h6m0 0v6m0-6L10 14" /> |
Prompt To Fix With AI
This is a comment left during a code review.
Path: app/(oss)/services/[id]/page.tsx
Line: 129:129
Comment:
**syntax:** Missing `a2 2 0 002 2h10` in the SVG path - the path appears incomplete compared to other external link icons in the codebase.
```suggestion
<path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M10 6H6a2 2 0 00-2 2v10a2 2 0 002 2h10a2 2 0 002-2v-4M14 4h6m0 0v6m0-6L10 14" />
```
How can I resolve this? If you propose a fix, please make it concise.0c82d20 to
77cb711
Compare
No description provided.