Fix/update tests #14
Open
Fix/update tests #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to const, updated spec/underpants.spec.js to reflect additional edge cases
…ling objects, updated tests
…some, every, pluck, map, partition, reject
…ough the function was not created
…od instead of _.every... corrected test string to be more specific
… additional string from _.first test
… test to use _.each and removed unnecessary console.log statements
…d map test to pluck tests for spec and test directories
…unnecessary console.log statements
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Updated tests to account for callback function inputs
I updated the tests for any _ method that prompts students to pass in additional arguments when callback functions are invoked. For instance, if the instructions prompt students to invoke the callback with the
current element, current index, and the array itselforthe current value, the current key, and the object itself, I created additional tests to check that the callbacks were receiving that data.Additional Changes