Skip to content

Update README.md #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
harveysanders wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #17

harveysanders wants to merge 1 commit into from

Conversation

@harveysanders
Copy link
Contributor

@harveysanders harveysanders commented Oct 24, 2018

No description provided.

@harveysanders
Copy link
Contributor Author

harveysanders commented Oct 24, 2018

I can't find the part about the npm test command needing to end with || : but these notes from Liv are probably helpful

jaykindell
jaykindell approved these changes Oct 24, 2018
View reviewed changes
Copy link

@jaykindell jaykindell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updates for posterity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jaykindell jaykindell jaykindell approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@harveysanders @jaykindell