Skip to content

Fix various bugs in eeprom handling #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
linuxianer99 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix various bugs in eeprom handling #46

linuxianer99 wants to merge 3 commits into from

Conversation

@linuxianer99
Copy link
Member

@linuxianer99 linuxianer99 commented Mar 8, 2022 •
edited
Loading

  • Alignment of struct using packed attribute to fix sizeof() return value
  • Exclude checksum itself from checksum calculation

Fixes #45

@linuxianer99 linuxianer99 requested a review from kedder March 8, 2022 07:27
@linuxianer99 linuxianer99 marked this pull request as ready for review March 8, 2022 07:31
MaxKellermann
MaxKellermann reviewed Mar 8, 2022
View reviewed changes
24c16.h Outdated
} t_24c16;

typedef struct {
typedef struct __attribute__((packed)){
Copy link
Collaborator

@MaxKellermann MaxKellermann Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a good idea. This moves the float field to a misaligned offset, and may crash with SIGBUS on some CPUs.

Copy link
Member Author

@linuxianer99 linuxianer99 Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you suggest as alternative ?? Add a stuff variable instead ?

Copy link
Contributor

@iglesiasmarianod iglesiasmarianod Mar 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to define the float inside the struct as the first item? This will reduce the padding to 1 byte. Then we can add one byte to the serial number to fill that padding byte.

@linuxianer99
Expand SN to 8 digits
f3d34d3 
Add padding for struct alignment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kedder kedder Awaiting requested review from kedder

2 more reviewers

@MaxKellermann MaxKellermann MaxKellermann left review comments

@iglesiasmarianod iglesiasmarianod iglesiasmarianod left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sensorcal not working

3 participants

@linuxianer99 @MaxKellermann @iglesiasmarianod