Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed alternative wrapper paths (
auth_user_and_invokeandcollect_fee_then_invoke) and standardized to a single recommended helper:collect_fee_and_invoke.Reasoning:
While we previously offered “flexibility” in how to compose authorization + fee-collection + invocation, it didn't provide meaningful practical benefits: implementers still had to manually construct authorization trees, which is complex and error-prone. Further, if approval is not bound atomically to the root call as a sub-invocation, it can open the door to front-running or a replay-style misuse. Long story short, the unopinionated approach, I was aiming for, turns out to be a possible footgun.
Added explicit expiration ledger validation for the case we don't rely on
token.approve()