Skip to content

Conversation

@brozorec
Copy link
Collaborator

@brozorec brozorec commented Jan 2, 2026

  1. Removed alternative wrapper paths (auth_user_and_invoke and collect_fee_then_invoke) and standardized to a single recommended helper: collect_fee_and_invoke.

    Reasoning:
    While we previously offered “flexibility” in how to compose authorization + fee-collection + invocation, it didn't provide meaningful practical benefits: implementers still had to manually construct authorization trees, which is complex and error-prone. Further, if approval is not bound atomically to the root call as a sub-invocation, it can open the door to front-running or a replay-style misuse. Long story short, the unopinionated approach, I was aiming for, turns out to be a possible footgun.

  2. Added explicit expiration ledger validation for the case we don't rely on token.approve()

@brozorec brozorec requested a review from ozgunozerk January 2, 2026 16:41
@brozorec brozorec self-assigned this Jan 2, 2026
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.07%. Comparing base (e23aafa) to head (985c21c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
- Coverage   96.11%   96.07%   -0.04%     
==========================================
  Files          54       54              
  Lines        5245     5201      -44     
==========================================
- Hits         5041     4997      -44     
  Misses        204      204              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brozorec brozorec merged commit b75a2e5 into main Jan 5, 2026
5 checks passed
@brozorec brozorec deleted the fee-abstraction-fix branch January 5, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants