[L-02] - refactor fixed point lib #544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #532
PR Checklist
Notes: this issue fix required us to expose a new variant of
mul_divwithout any rounding, because that functionality is used in a lot of places inWAD, and having this function as a helper inWADdoes make less sense then having it in our fixed point library.The best place to include that, was in the trait. Then, I've realized some inconsistencies between I256 and i128 libraries.
In short, changing the trait, and fixing the inconsistencies, led me to refactoring the fixed point library altogether.
Here are the summary of the changes:
mul_divRoundingenum, which isTruncatemuldivandchecked_muldivstandalone functions toi256as well, because, any difference acrossi128andi256is confusingcheckedandnon_checkedfunctions ini256was not consistent withi128, changed them as wellfixed_point.rstest, because we don't have any function/method exposed from themod.rsfile anymoreSorobanMulDiv, (previouslySorobanFixedPoint), because we are not providing a suite of fixed point arithmetic math under that trait, but only the variants ofmul_div