Skip to content

refactor(access): adding more test cases for shielded access control#411

Merged
andrew-fleming merged 3 commits intoshielded-access-controlfrom
refactor/add-more-test-cases
Mar 27, 2026
Merged

refactor(access): adding more test cases for shielded access control#411
andrew-fleming merged 3 commits intoshielded-access-controlfrom
refactor/add-more-test-cases

Conversation

@0xisk
Copy link
Copy Markdown
Member

@0xisk 0xisk commented Mar 27, 2026

Types of changes

What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

PR Checklist

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@0xisk 0xisk requested review from a team as code owners March 27, 2026 14:20
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 27, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ec342ffd-2b8a-4293-b26f-88849ad94819

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/add-more-test-cases

Comment @coderabbitai help to get the list of available commands and usage tips.

@0xisk 0xisk force-pushed the refactor/add-more-test-cases branch from 45bf4eb to cd52159 Compare March 27, 2026 14:44
Copy link
Copy Markdown
Contributor

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrew-fleming andrew-fleming merged commit 3c41f95 into shielded-access-control Mar 27, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants