Document support for secrets in README#199
Open
JacobSnyder wants to merge 2 commits intoOpenZWave:masterfrom
Open
Document support for secrets in README#199JacobSnyder wants to merge 2 commits intoOpenZWave:masterfrom
JacobSnyder wants to merge 2 commits intoOpenZWave:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I try to avoid putting secrets into environment variables wherever it's supported. I noticed that the source mention Docker secrets instead of the environment variables specified in this README.
I tried it and it works! Here's the relevant snippets I found from the logs:
OZW_NETWORK_KEY
OZW_AUTH_KEY
The auth key doesn't have as much logging as the network key, but it does have some.
MQTT_PASSWORD
There isn't any "positive" logging that confirms that the MQTT password has been picked up, but all of the "negative" logging that indicates problems includes the phrase "MQTT_PASSWORD" and I don't have any instances of that in my logs. And, my MQTT broker logged a successful connection from OZW.
Thanks!