Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Nix development environment by bumping nixpkgs from version 25.05 to 25.11 and upgrading Verilator from version 5.040 to 5.042 with an optimization patch to improve simulation performance.
- Upgrades nixpkgs to nixos-25.11
- Updates Verilator to version 5.042 with new source hash
- Replaces nixpkgs upstream patches with a performance optimization patch from PR #6822
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| flake.nix | Updates nixpkgs reference to 25.11, upgrades Verilator to 5.042, and applies optimization patch for improved mux performance |
| flake.lock | Updates lock file to reflect nixpkgs 25.11 with corresponding revision and hash updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Is it already replaced by #71? |
Member
Author
Yan-Muzi
pushed a commit
that referenced
this pull request
Jan 26, 2026
Including: - bump nix flake - verilator 5.040 -> 5.044 - clang default (18 on ubuntu 24.04, or 14 on ubuntu 22.04) -> 19 - openjdk 11 -> 21 Also: - add llvmPackages.bolt in nix devshell for pgo - print clang version in nix devshell Close #70
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overrides to verilator:
This should have some benefit in improving simulation speed