Conversation
|
Hi, thanks for your PR. This is a nice idea to improve our checkpoint flow. But there is still some issues that should be fixed before merging this PR.
For your contribution, I also have some questions:
|
|
Hi ,thanks for your valuable feedback and recognition of the PR! I totally agree with all your suggestions and will address each point promptly: 1. PR Description & Commit MessageI’ll add a detailed English description to the PR (including key changes, design logic, and compatibility notes) and update all commit messages to follow the English convention. This will be completed within next week. 2. XiangShan-doc UpdateI’ll migrate the "Motivation" and "Experimental Results" sections from the PDF to 3. Code IssuesNo problem! Please feel free to point out the specific code issues – I’ll fix them immediately and add corresponding test cases to avoid regressions. 4. Test Results EnhancementI fully understand the need for stronger validation. I’ll try to expand the test suite. 5. Questions About CacheReplay
Thanks again for your guidance! |
修改文档.pdf