Skip to content

feat(device): Supports selective difftest of mmio address space#740

Merged
xyyy1420 merged 9 commits intomasterfrom
selective_mmio_diff
Dec 31, 2024
Merged

feat(device): Supports selective difftest of mmio address space#740
xyyy1420 merged 9 commits intomasterfrom
selective_mmio_diff

Conversation

@xyyy1420
Copy link
Contributor

@xyyy1420 xyyy1420 commented Dec 26, 2024 •
edited
Loading

split from #714

@xyyy1420
feat(selective mmio diff): Supports selective difftest of mmio addres…
cc16351 
…s space

Signed-off-by: jiaxiaoyu <xyyy1420@gmail.com>
@xyyy1420
trace include/device/flash.h
04188f3 
Signed-off-by: jiaxiaoyu <xyyy1420@gmail.com>
@xyyy1420
Copy link
Contributor Author

xyyy1420 commented Dec 26, 2024 •
edited
Loading

Ready for review @shinezyy @poemonsense @cebarobot

@xyyy1420
fix(skip flag check): migrate difftest skip check to map_read and map…
75f82ff 
…_write

Signed-off-by: jiaxiaoyu <xyyy1420@gmail.com>
@xyyy1420
fix: fix some issue
68c38d9 
Signed-off-by: jiaxiaoyu <xyyy1420@gmail.com>
shinezyy
shinezyy requested changes Dec 27, 2024
View reviewed changes
@xyyy1420
fix: rename skip_ref_flag to mmio_diff_flag
2c31dd9 
Signed-off-by: jiaxiaoyu <xyyy1420@gmail.com>
poemonsense
poemonsense reviewed Dec 27, 2024
View reviewed changes
poemonsense
poemonsense reviewed Dec 27, 2024
View reviewed changes
@xyyy1420
fix: rename mmio_diff_flag to mmio_diff_type
c88b1ac 
Signed-off-by: jiaxiaoyu <xyyy1420@gmail.com>
@poemonsense
Copy link
Member

poemonsense commented Dec 27, 2024

I propose using feat(device) for the title. Then there will be no duplicate words

@xyyy1420 xyyy1420 changed the title feat(selective mmio diff): Supports selective difftest of mmio address space feat(device): Supports selective difftest of mmio address space Dec 27, 2024
@xyyy1420
feat(mmio_map): add 'add_mmio_map_with_diff' api
3b6b46f 
Signed-off-by: jiaxiaoyu <xyyy1420@gmail.com>
@xyyy1420
fix: delete useless code
db4a2f5 
Signed-off-by: jiaxiaoyu <xyyy1420@gmail.com>
cebarobot
cebarobot reviewed Dec 30, 2024
View reviewed changes
Copy link
Member

@cebarobot cebarobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see any codes that uses mmio_diff_type. Are they in the next PR? Also, Could you tell more about the background? Why we need selective difftest of mmio address space?

By the way, Port IO is only used in x86, which is actually useless now. But it's always good to provide those codes.

Current source codes LGTM.

@xyyy1420
Copy link
Contributor Author

xyyy1420 commented Dec 30, 2024 •
edited by shinezyy
Loading

I didn't see any codes that uses mmio_diff_type. Are they in the next PR? Also, Could you tell more about the background? Why we need selective difftest of mmio address space?

By the way, Port IO is only used in x86, which is actually useless now. But it's always good to provide those codes.

Current source codes LGTM.

no code is using MMIO_DIFF_TYPE, but it is using elements defined in this type;
i want put the register state and gcpt into flash, this requires flash as a device that can properly use difftest, so i think we need to selectively difftest for different mmio address spaces

shinezyy
shinezyy approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@shinezyy shinezyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cebarobot
cebarobot approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@cebarobot cebarobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

poemonsense
poemonsense approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@poemonsense poemonsense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor style improvements

Others look good to me

@xyyy1420
fix: some minor style improvements
00fcadb 
Signed-off-by: jiaxiaoyu <xyyy1420@gmail.com>
@xyyy1420
Copy link
Contributor Author

xyyy1420 commented Dec 31, 2024

Some minor style improvements

Others look good to me

already fixed

@xyyy1420 xyyy1420 merged commit d10322d into master Dec 31, 2024
7 checks passed
@xyyy1420 xyyy1420 deleted the selective_mmio_diff branch December 31, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shinezyy shinezyy shinezyy approved these changes

@poemonsense poemonsense poemonsense approved these changes

@cebarobot cebarobot cebarobot approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xyyy1420 @poemonsense @shinezyy @cebarobot