refactor: complete migration of isa-related logic to isa.mk#608
Open
refactor: complete migration of isa-related logic to isa.mk#608
Conversation
Signed-off-by: jiaxiaoyu <xyyy1420@gmail.com>
shinezyy
reviewed
Oct 29, 2024
Contributor
shinezyy
left a comment
shinezyy
left a comment
There was a problem hiding this comment.
LGTM. But can you add some motivation why we do this? just for code clean-up or for other features?
Signed-off-by: jiaxiaoyu <xyyy1420@gmail.com>
Contributor
Author
The original build command is |
shinezyy
approved these changes
Oct 31, 2024
Contributor
shinezyy
left a comment
shinezyy
left a comment
There was a problem hiding this comment.
plz squash commits, and add motivation into commit message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.