Skip to content

add restore memtrace #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
greenfool wants to merge 3 commits into
base: xs-dev
Choose a base branch
from
Open

add restore memtrace #755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c016b5
add restore memtrace
greenfool Jan 30, 2026
ba41007
style: delete debug info
greenfool Feb 5, 2026
c81f6ec
style: Remove debug output from system constructor
greenfool Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions configs/common/Options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ def addNoISAOptions(parser, configure_xiangshan=False):
parser.add_argument("--l1-to-l2-pf-hint", action="store_true")
parser.add_argument("--l2-to-l3-pf-hint", action="store_true")

parser.add_argument("--memtrace_path", type=str, default=None) # Memtrace file path for restoring the microarchitectural state in L3 Cache

parser.add_argument("--num-dirs", type=int, default=1)
parser.add_argument("--num-l2caches", type=int, default=1)
parser.add_argument("--num-l3caches", type=int, default=1)
Expand Down
3 changes: 2 additions & 1 deletion configs/common/Simulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,8 @@ def run_vanilla(options, root, testsys, cpu_class):

checkpoint_dir = None
root.apply_config(options.param)
m5.instantiate(checkpoint_dir)
# add path for generic_rv_cpt and memtrace_path
m5.instantiate(pmem_file_path=options.generic_rv_cpt,mem_trace_file=options.memtrace_path,ckpt_dir=checkpoint_dir)
Comment on lines +824 to +825
Copy link

@coderabbitai coderabbitai bot Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

rg -nP '\bm5\.instantiate\s*\(' -A 2

Repository: OpenXiangShan/GEM5

Length of output: 12263

🏁 Script executed:

sed -n '65,100p' src/python/m5/simulate.py

Repository: OpenXiangShan/GEM5

Length of output: 1254

🏁 Script executed:

sed -n '648,656p' configs/common/Simulation.py

Repository: OpenXiangShan/GEM5

Length of output: 496

Fix the m5.instantiate call at line 652 to match the new signature.

The new signature at line 825 requires two positional arguments (pmem_file_path and mem_trace_file), but line 652 in the same file calls m5.instantiate(checkpoint_dir) with only one argument. This will fail at runtime with a TypeError. Line 652 must be updated to pass both required arguments (or use keyword arguments like line 825).

🤖 Prompt for AI Agents 
In `@configs/common/Simulation.py` around lines 824 - 825, Update the earlier call
to m5.instantiate so it matches the new signature used later: pass both
pmem_file_path and mem_trace_file (or use keyword args) in addition to
checkpoint_dir; locate the call to m5.instantiate(checkpoint_dir) and change it
to include options.generic_rv_cpt and options.memtrace_path (e.g.,
m5.instantiate(pmem_file_path=options.generic_rv_cpt,
mem_trace_file=options.memtrace_path, ckpt_dir=checkpoint_dir)) so the function
receives the required two positional/keyword arguments.


# Handle the max tick settings now that tick frequency was resolved
# during system instantiation
Expand Down
5 changes: 5 additions & 0 deletions configs/common/xiangshan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,13 @@ def config_xiangshan_inputs(args: argparse.Namespace, sys):
sys.workload.raw_bootloader = True
else:
sys.gcpt_restorer_file = gcpt_restorer
if args.memtrace_path is not None:
sys.restore_from_memtrace = True
sys.memtrace_file = args.memtrace_path
# enable h checkpoint
if args.enable_h_gcpt:
sys.enable_h_gcpt = True

# configure DRAMSim input
if args.mem_type == 'DRAMsim3' and args.dramsim3_ini is None:
# use relative path to find the dramsim3 ini file, from configs/common/ to root
Expand Down Expand Up @@ -274,6 +278,7 @@ def build_xiangshan_system(args):
ruby = True

# Create system using FS mode with trace-specific memory configuration
# memtrace
test_sys = makeBareMetalXiangshanSystem('timing', SysConfig(mem=args.mem_size), None, np=np, ruby=ruby)

# CRITICAL FIX: Configure trace-specific memory ranges and functional TLB for trace mode
Expand Down
1 change: 1 addition & 0 deletions configs/example/kmhv3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ def setKmhV3Params(args, system):
system.l3.prefetch_can_offload = False
system.l3.num_slices = 4


if __name__ == '__m5_main__':
FutureClass = None

Expand Down
10 changes: 10 additions & 0 deletions src/mem/cache/cache_blk.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,16 @@ class CacheBlk : public TaggedEntry
}
}

// Public versions of some protected setters for use in restore L3 microarchitectural state
/** Set the task id value. */
void setTaskId_pub(const uint32_t task_id) { _taskId = task_id; }

/** Set the source requestor id. */
void setSrcRequestorId_pub(const uint32_t id) { _srcRequestorId = id; }

/** Set the current tick as this block's insertion tick. */
void setTickInserted_pub() { _tickInserted = curTick(); }

/** Set the XS metadata. */
void setXsMetadata(const Request::XsMetadata &xs_meta)
{
Expand Down
2 changes: 2 additions & 0 deletions src/mem/cache/replacement_policies/base.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ class Base : public SimObject
virtual void reset(const std::shared_ptr<ReplacementData>&
replacement_data) const = 0;

virtual void reset4memtrace(const std::shared_ptr<ReplacementData>&
replacement_data,int priority) const = 0;
/**
* Find replacement victim among candidates.
*
Expand Down
3 changes: 3 additions & 0 deletions src/mem/cache/replacement_policies/bip_rp.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ class BIP : public LRU
*/
void reset(const std::shared_ptr<ReplacementData>& replacement_data) const
override;
void reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data,int priority) const override
{
}
Comment on lines +79 to +81
Copy link

@coderabbitai coderabbitai bot Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# Find all reset4memtrace overrides in replacement policies
rg -n "reset4memtrace\(" src/mem/cache/replacement_policies --type-add 'h:*.hh:*.hpp' -t h

Repository: OpenXiangShan/GEM5

Length of output: 121

🏁 Script executed:

# Check BIP class definition to confirm it derives from LRU
head -50 src/mem/cache/replacement_policies/bip_rp.hh

Repository: OpenXiangShan/GEM5

Length of output: 2267

🏁 Script executed:

# Check LRU's reset4memtrace implementation
rg -A 5 "void reset4memtrace" src/mem/cache/replacement_policies/lru_rp.hh

Repository: OpenXiangShan/GEM5

Length of output: 327

🏁 Script executed:

# Find all reset4memtrace implementations (not just declarations)
rg -A 5 "reset4memtrace" src/mem/cache/replacement_policies/ --type c --type h

Repository: OpenXiangShan/GEM5

Length of output: 44

🏁 Script executed:

# Check the full BIP class definition
cat src/mem/cache/replacement_policies/bip_rp.hh

Repository: OpenXiangShan/GEM5

Length of output: 3354

🏁 Script executed:

# Find what classes override reset4memtrace
grep -r "reset4memtrace" src/mem/cache/replacement_policies --include="*.hh" --include="*.cc" -B 3

Repository: OpenXiangShan/GEM5

Length of output: 6326

🏁 Script executed:

# Get the full LRU::reset4memtrace implementation
rg -A 10 "LRU::reset4memtrace" src/mem/cache/replacement_policies/

Repository: OpenXiangShan/GEM5

Length of output: 982

🏁 Script executed:

# Check BRRIP reset4memtrace implementation for comparison
rg -A 5 "class BRRIP" src/mem/cache/replacement_policies/brrip_rp.hh

Repository: OpenXiangShan/GEM5

Length of output: 213

🏁 Script executed:

# Get BRRIP's reset4memtrace implementation
cat src/mem/cache/replacement_policies/brrip_rp.hh | grep -A 5 "reset4memtrace"

Repository: OpenXiangShan/GEM5

Length of output: 249

🏁 Script executed:

# Check BRRIP class hierarchy
head -50 src/mem/cache/replacement_policies/brrip_rp.hh | grep -E "class BRRIP|public"

Repository: OpenXiangShan/GEM5

Length of output: 44

🏁 Script executed:

# Check MRU reset4memtrace implementation
cat src/mem/cache/replacement_policies/mru_rp.hh | grep -A 5 "reset4memtrace"

Repository: OpenXiangShan/GEM5

Length of output: 260

🏁 Script executed:

# Check Random reset4memtrace implementation
cat src/mem/cache/replacement_policies/random_rp.hh | grep -A 5 "reset4memtrace"

Repository: OpenXiangShan/GEM5

Length of output: 245

🏁 Script executed:

# Get full BRRIP class definition to check inheritance
cat src/mem/cache/replacement_policies/brrip_rp.hh | head -100

Repository: OpenXiangShan/GEM5

Length of output: 3909

🏁 Script executed:

# Get full MRU class definition
cat src/mem/cache/replacement_policies/mru_rp.hh | head -80

Repository: OpenXiangShan/GEM5

Length of output: 2958

🏁 Script executed:

# Check which policies inherit from LRU
grep -l "public LRU" src/mem/cache/replacement_policies/*.hh

Repository: OpenXiangShan/GEM5

Length of output: 160

🏁 Script executed:

# Check WeightedLRU reset4memtrace implementation
cat src/mem/cache/replacement_policies/weighted_lru_rp.hh | grep -A 5 "reset4memtrace"

Repository: OpenXiangShan/GEM5

Length of output: 44

🏁 Script executed:

# Check if WeightedLRU overrides reset4memtrace
cat src/mem/cache/replacement_policies/weighted_lru_rp.hh | head -100

Repository: OpenXiangShan/GEM5

Length of output: 3313

🏁 Script executed:

# Check if WeightedLRU class definition exists and what it inherits
grep "class WeightedLRU" src/mem/cache/replacement_policies/weighted_lru_rp.hh -A 5

Repository: OpenXiangShan/GEM5

Length of output: 218

BIP's empty reset4memtrace override disables LRU-based memtrace ordering.

Since BIP derives from LRU, this no-op override prevents lastTouchTick from being set during memtrace warmup (which LRU::reset4memtrace does), making replacement order arbitrary. Delegate to LRU::reset4memtrace(...) or remove the override to inherit it, consistent with WeightedLRU's pattern.

Suggested fix 
-    void reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data,int priority) const override
-    {     
-    }     
+    void reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data,
+                        int priority) const override
+    {
+        LRU::reset4memtrace(replacement_data, priority);
+    }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
void reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data,int priority) const override
{
}
void reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data,
int priority) const override
{
LRU::reset4memtrace(replacement_data, priority);
}
🤖 Prompt for AI Agents 
In `@src/mem/cache/replacement_policies/bip_rp.hh` around lines 79 - 81, The BIP
policy's override of reset4memtrace is a no-op and prevents LRU's memtrace
warmup behavior; update the BIP implementation so it delegates to the base LRU
implementation (call LRU::reset4memtrace(replacement_data, priority)) or simply
remove the override to inherit LRU::reset4memtrace, matching WeightedLRU's
pattern and ensuring lastTouchTick is set during memtrace warmup.

};

} // namespace replacement_policy
Expand Down
4 changes: 3 additions & 1 deletion src/mem/cache/replacement_policies/brrip_rp.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,9 @@ class BRRIP : public Base
*/
void reset(const std::shared_ptr<ReplacementData>& replacement_data) const
override;

void reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data,int priority) const override
{
}
Comment on lines +145 to +147
Copy link

@coderabbitai coderabbitai bot Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Implement reset4memtrace to initialize BRRIP state.

Leaving the memtrace reset hook empty means BRRIP replacement metadata won’t be initialized during memtrace warmup, which undermines the feature and can skew victim selection. At minimum, fall back to the normal reset() behavior, or map priority to an RRPV value.

🛠️ Suggested fallback 
-    void reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data,int priority) const override
-    {     
-    }   
+    void reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data,int priority) const override
+    {
+        reset(replacement_data);
+        (void)priority;
+    }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
void reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data,int priority) const override
{
}
void reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data,int priority) const override
{
reset(replacement_data);
(void)priority;
}
🤖 Prompt for AI Agents 
In `@src/mem/cache/replacement_policies/brrip_rp.hh` around lines 145 - 147, The
reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data, int
priority) const override is currently empty; implement it to initialize BRRIP
metadata during memtrace warmup by either delegating to the existing reset()
method (e.g., call reset(replacement_data)) or by mapping the provided priority
to an RRPV value and setting each line's RRPV in the ReplacementData/BRRIP state
accordingly (ensure you update the same structures used by get/set RRPV methods
so victim selection behaves correctly).

/**
* Find replacement victim using rrpv.
*
Expand Down
3 changes: 3 additions & 0 deletions src/mem/cache/replacement_policies/dueling_rp.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,9 @@ class Dueling : public Base
const PacketPtr pkt) override;
void reset(const std::shared_ptr<ReplacementData>& replacement_data) const
override;
void reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data,int priority) const override
{
}
ReplaceableEntry* getVictim(const ReplacementCandidates& candidates) const
override;
std::shared_ptr<ReplacementData> instantiateEntry() override;
Expand Down
4 changes: 3 additions & 1 deletion src/mem/cache/replacement_policies/fifo_rp.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ class FIFO : public Base
*/
void reset(const std::shared_ptr<ReplacementData>& replacement_data) const
override;

void reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data,int priority) const override
{
}
/**
* Find replacement victim using insertion timestamps.
*
Expand Down
4 changes: 3 additions & 1 deletion src/mem/cache/replacement_policies/lfu_rp.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ class LFU : public Base
*/
void reset(const std::shared_ptr<ReplacementData>& replacement_data) const
override;

void reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data,int priority) const override
{
}
/**
* Find replacement victim using reference frequency.
*
Expand Down
9 changes: 9 additions & 0 deletions src/mem/cache/replacement_policies/lru_rp.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,15 @@ LRU::reset(const std::shared_ptr<ReplacementData>& replacement_data) const
replacement_data)->lastTouchTick = curTick();
}

void
LRU::reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data,int priority) const
{
// Set last touch timestamp
// Here we use priority to set lastTouchTick, the lower the priority, the older the lastTouchTick
std::static_pointer_cast<LRUReplData>(
replacement_data)->lastTouchTick = curTick() - priority;
}
Comment on lines +73 to +80
Copy link

@coderabbitai coderabbitai bot Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Search for Tick typedef and using declarations
echo "=== Tick type definitions ==="
rg -n "typedef\s+.*Tick|using\s+Tick" -S 2>/dev/null || echo "No matches found"

echo -e "\n=== reset4memtrace call sites ==="
rg -n "reset4memtrace\(" -S 2>/dev/null || echo "No matches found"

echo -e "\n=== File structure context ==="
fd -t f "lru_rp\.(cc|hh)" | head -5

Repository: OpenXiangShan/GEM5

Length of output: 4146

🏁 Script executed:

#!/bin/bash
# Look for LRUReplData definition to understand lastTouchTick type
rg -n "struct\s+LRUReplData|class\s+LRUReplData" -A 10 -S 2>/dev/null || echo "No struct/class found"

Repository: OpenXiangShan/GEM5

Length of output: 847

🏁 Script executed:

#!/bin/bash
# Check the header file for reset4memtrace declaration and comments
fd -t f "lru_rp\.hh" -exec cat {} \;

Repository: OpenXiangShan/GEM5

Length of output: 249

🏁 Script executed:

#!/bin/bash
# Read the LRU header file
cat src/mem/cache/replacement_policies/lru_rp.hh

Repository: OpenXiangShan/GEM5

Length of output: 4365

🏁 Script executed:

#!/bin/bash
# Check the call sites to understand what priority values are passed
echo "=== sector_tags.cc reset4memtrace call ==="
rg -n -B 5 -A 2 "reset4memtrace\(blk->replacementData,priority\)" src/mem/cache/tags/sector_tags.cc

echo -e "\n=== base_set_assoc.hh reset4memtrace call ==="
rg -n -B 5 -A 2 "reset4memtrace\(blk->replacementData,priority\)" src/mem/cache/tags/base_set_assoc.hh

Repository: OpenXiangShan/GEM5

Length of output: 512

🏁 Script executed:

#!/bin/bash
# Check how priority is calculated and what values it can have
rg -n "priority\s*=" src/mem/cache/tags/sector_tags.cc | head -20
rg -n "priority\s*=" src/mem/cache/tags/base_set_assoc.hh | head -20

Repository: OpenXiangShan/GEM5

Length of output: 44

🏁 Script executed:

#!/bin/bash
# Find where updateRp is called with priority parameter
rg -n "updateRp\(" -B 3 -A 1 | head -60

Repository: OpenXiangShan/GEM5

Length of output: 2056

🏁 Script executed:

#!/bin/bash
# Check for any documentation or comments about priority in memtrace context
rg -n "memtrace|priority" src/mem/cache/tags/sector_tags.cc -B 2 -A 2 | head -80

Repository: OpenXiangShan/GEM5

Length of output: 217

🏁 Script executed:

#!/bin/bash
# Look for the definition/implementation of updateRp callers
rg -n "\.updateRp\(" src/mem/cache -r --type cc --type hh | head -30

Repository: OpenXiangShan/GEM5

Length of output: 88

🏁 Script executed:

#!/bin/bash
# Find where memtrace_priority is defined and used
rg -n "memtrace_priority" src/mem/cache -B 3 -A 3

Repository: OpenXiangShan/GEM5

Length of output: 1181

🏁 Script executed:

#!/bin/bash
# Check the base.cc file around line 397 for more context
sed -n '380,415p' src/mem/cache/tags/base.cc

Repository: OpenXiangShan/GEM5

Length of output: 1547

🏁 Script executed:

#!/bin/bash
# Search for Tick underflow or saturation patterns in the codebase
rg -n "saturate|underflow|std::min|std::max.*Tick" src/ -t cc -t hh | head -40

Repository: OpenXiangShan/GEM5

Length of output: 88

🏁 Script executed:

#!/bin/bash
# Get more context around where memtrace_priority is used
sed -n '360,410p' src/mem/cache/tags/base.cc

Repository: OpenXiangShan/GEM5

Length of output: 2166

🏁 Script executed:

#!/bin/bash
# Check if there are any bounds checks on priority/rank before use
rg -n "priority|rank" src/mem/cache/tags/base.cc -B 2 -A 2 | head -100

Repository: OpenXiangShan/GEM5

Length of output: 870

🏁 Script executed:

#!/bin/bash
# Check how other implementations of reset4memtrace handle the priority parameter
rg -n "reset4memtrace" -A 5 src/mem/cache/replacement_policies/ | head -80

Repository: OpenXiangShan/GEM5

Length of output: 6363

🏁 Script executed:

#!/bin/bash
# Check if there's any validation on the rank value before use
sed -n '360,380p' src/mem/cache/tags/base.cc

Repository: OpenXiangShan/GEM5

Length of output: 831

🏁 Script executed:

#!/bin/bash
# Look for any documentation about memtrace file format or constraints
rg -n "memtrace|rank.*file|trace.*format" src/mem/cache/tags/base.cc -B 2 -A 2

Repository: OpenXiangShan/GEM5

Length of output: 1166

Guard against tick underflow when applying memtrace priority.

The priority parameter is parsed from a memtrace file via std::stoi(rank) without validation. If priority is negative or exceeds curTick(), the subtraction curTick() - priority causes unsigned integer underflow, inverting LRU ordering during warmup. Clamp or validate priority to prevent silent corruption of cache replacement state.

🤖 Prompt for AI Agents 
In `@src/mem/cache/replacement_policies/lru_rp.cc` around lines 73 - 80, In
LRU::reset4memtrace, guard against unsigned underflow when computing
lastTouchTick = curTick() - priority by validating/clamping the parsed memtrace
priority: ensure priority is non-negative and not greater than curTick() before
subtracting. Locate the method LRU::reset4memtrace and the use of
std::static_pointer_cast<LRUReplData>(replacement_data)->lastTouchTick, and
replace the direct subtraction with a clamped value (e.g., use min(max(priority,
0), curTick())) or equivalent logic so lastTouchTick never underflows.


ReplaceableEntry*
LRU::getVictim(const ReplacementCandidates& candidates) const
{
Expand Down
2 changes: 2 additions & 0 deletions src/mem/cache/replacement_policies/lru_rp.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ class LRU : public Base
void reset(const std::shared_ptr<ReplacementData>& replacement_data) const
override;

void reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data,int priority) const override;

/**
* Find replacement victim using LRU timestamps.
*
Expand Down
4 changes: 3 additions & 1 deletion src/mem/cache/replacement_policies/mru_rp.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ class MRU : public Base
*/
void reset(const std::shared_ptr<ReplacementData>& replacement_data) const
override;

void reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data,int priority) const override
{
}
/**
* Find replacement victim using access timestamps.
*
Expand Down
4 changes: 3 additions & 1 deletion src/mem/cache/replacement_policies/random_rp.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,9 @@ class Random : public Base
*/
void reset(const std::shared_ptr<ReplacementData>& replacement_data) const
override;

void reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data,int priority) const override
{
}
/**
* Find replacement victim at random.
*
Expand Down
4 changes: 3 additions & 1 deletion src/mem/cache/replacement_policies/second_chance_rp.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,9 @@ class SecondChance : public FIFO
*/
void reset(const std::shared_ptr<ReplacementData>& replacement_data) const
override;

void reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data,int priority) const override
{
}
/**
* Find replacement victim using insertion timestamps and second chance
* bit.
Expand Down
4 changes: 3 additions & 1 deletion src/mem/cache/replacement_policies/ship_rp.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,9 @@ class SHiP : public BRRIP
const PacketPtr pkt) override;
void reset(const std::shared_ptr<ReplacementData>& replacement_data) const
override;

void reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data,int priority) const override
{
}
/**
* Instantiate a replacement data entry.
*
Expand Down
4 changes: 3 additions & 1 deletion src/mem/cache/replacement_policies/tree_plru_rp.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,9 @@ class TreePLRU : public Base
*/
void reset(const std::shared_ptr<ReplacementData>& replacement_data) const
override;

void reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data,int priority) const override
{
}
/**
* Find replacement victim using TreePLRU bits. It is assumed that all
* candidates share the same replacement data tree.
Expand Down
4 changes: 3 additions & 1 deletion src/mem/cache/replacement_policies/xs_drrip_rp.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,9 @@ class XSDRRIP : public Base

void reset(const std::shared_ptr<ReplacementData>& replacement_data) const
override;

void reset4memtrace(const std::shared_ptr<ReplacementData>& replacement_data,int priority) const override
{
}
/**
* Find victim for replacement
*/
Expand Down
Loading