x86_64: Update POST line ending for Quark #51
Conversation
Quark server expects payload to end in two newlines. Delimit all POST requests so that the server can parse them properly. Signed-off-by: Nicholas Tsirakis <tsirakisn@ainfosec.com>
|
Do you know if this breaks uid? Would it make sense to move the CRLF addition into XUIXhr.post or XUIXhr.send so that individual callers don't need to be updated? There is only 1, so I guess it doesn't really matter. The PR is weird since it's a merge commit and the actual commit. The change itself seems fine. |
|
@jandryuk, Jed did an x64 build with Christopher's ocaml PRs and it looked ok, let me verify the line ending doesn't break anything. Also I'll drop the merge commit, I had Niko PR to my feature branch during development |
|
Tested on build 6451, UI log messages come through but syslog prints # 015 and # 012 instead of the line ending sequence, as they must not be escaped. Functionally, no change, just the added junk at the end of the debug message. |
|
Great. Thanks for checking. |
|
Merge commit dropped |
jandryuk
left a comment
jandryuk
left a comment
There was a problem hiding this comment.
LGTM
If someone cares, they could make uid strip off the trailing \r\n\r\n.
2 participants
No description provided.