Merged
Conversation
Extend import rules to be autofixable and include: - no duplicates - consistent type imports separated on top level Includes adding `eslint-plugin-import` to dev dependencies.
kaljarv
force-pushed
the
build-eslint-import-rules
branch
from
54d6f8f to
c4803f4
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes import formatting across the repo by updating the shared ESLint configuration (and dependencies) to enforce consistent, auto-fixable import ordering and type import style.
Changes:
- Add
eslint-plugin-importand enable import hygiene rules (import/first,import/newline-after-import,import/no-duplicates,import/consistent-type-specifier-style). - Configure TypeScript type import consistency to prefer
import typewith separate type-only imports. - Apply repo-wide auto-fixes to split type/value imports, sort imports, and add required newlines.
Reviewed changes
Copilot reviewed 143 out of 144 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Adds lockfile entries for eslint-plugin-import and its dependencies. |
| package.json | Adds eslint-plugin-import to root devDependencies. |
| packages/shared-config/package.json | Adds eslint-plugin-import to the shared config package dependencies. |
| packages/shared-config/eslint.config.mjs | Registers eslint-plugin-import and enables import consistency rules. |
| tests/tests/utils/buildRoute.ts | Splits type-only import into import type. |
| packages/question-info/src/core/infoGeneration.type.ts | Consolidates type imports from the same module. |
| packages/matching/tests/utils.ts | Splits value vs type imports to satisfy new rules. |
| packages/matching/src/space/position.ts | Splits value vs type imports. |
| packages/matching/src/space/matchingSpace.ts | Splits value vs type imports. |
| packages/matching/src/question/ordinalQuestion.ts | Splits value vs type imports. |
| packages/matching/src/question/categoricalQuestion.ts | Splits value vs type imports. |
| packages/matching/src/missingValue/impute.ts | Splits value vs type imports. |
| packages/matching/src/match/matchBase.ts | Splits value vs type imports. |
| packages/matching/src/distance/metric.ts | Splits value vs type imports. |
| packages/matching/src/distance/measure.ts | Consolidates type imports from the same module. |
| packages/matching/src/algorithms/matchingAlgorithm.ts | Splits value vs type imports. |
| packages/matching/examples/example.ts | Splits value vs type imports. |
| packages/llm/tests/llmProvider.test.ts | Moves imports to comply with import/first and separates type imports. |
| packages/llm/src/prompts/promptRegistry.ts | Splits value vs type imports. |
| packages/filters/tests/filter.test.ts | Splits value vs type imports. |
| packages/filters/src/group/filterGroup.ts | Splits value vs type imports. |
| packages/filters/src/filter/text/textPropertyFilter.ts | Splits value vs type imports. |
| packages/filters/src/filter/text/textFilter.ts | Splits value vs type imports. |
| packages/filters/src/filter/number/numberFilter.ts | Splits value vs type imports. |
| packages/filters/src/filter/enumerated/objectFilter.ts | Splits value vs type imports. |
| packages/filters/src/filter/enumerated/enumeratedFilter.ts | Splits value vs type imports. |
| packages/filters/src/filter/enumerated/choiceQuestionFilter.ts | Splits value vs type imports. |
| packages/filters/src/filter/base/filter.ts | Splits value vs type imports. |
| packages/data/src/utils/filter.test.ts | Adds newline after imports. |
| packages/data/src/utils/ensureValue.ts | Splits value vs type imports. |
| packages/data/src/utils/choice.ts | Splits value vs type imports. |
| packages/data/src/utils/choice.test.ts | Adds newline after imports. |
| packages/data/src/testUtils/testData.ts | Splits value vs type imports. |
| packages/data/src/testUtils/localizedTestData.ts | Splits value vs type imports. |
| packages/data/src/objects/questions/variants/variants.ts | Consolidates type imports. |
| packages/data/src/objects/questions/variants/singleChoiceOrdinalQuestion.ts | Splits value vs type imports (multi-line type import). |
| packages/data/src/objects/questions/variants/singleChoiceCategoricalQuestion.ts | Splits value vs type imports. |
| packages/data/src/objects/questions/variants/numberQuestion.ts | Splits value vs type imports (multi-line type import). |
| packages/data/src/objects/questions/variants/dateQuestion.ts | Splits value vs type imports (multi-line type import). |
| packages/data/src/objects/questions/variants/booleanQuestion.ts | Splits value vs type imports. |
| packages/data/src/objects/questions/base/singleChoiceQuestion.ts | Splits value vs type imports. |
| packages/data/src/objects/questions/base/multipleChoiceQuestion.ts | Splits value vs type imports (multi-line type import). |
| packages/data/src/objects/questions/base/choiceQuestion.ts | Splits value vs type imports and consolidates type-only imports. |
| packages/data/src/objects/nominations/variants/variants.ts | Consolidates type imports (adds Id into the main type import). |
| packages/data/src/objects/nominations/variants/organizationNomination.ts | Splits value vs type imports (multi-line type import). |
| packages/data/src/objects/nominations/variants/factionNomination.ts | Splits value vs type imports (multi-line type import). |
| packages/data/src/objects/nominations/variants/candidateNomination.ts | Splits value vs type imports (multi-line type import). |
| packages/data/src/objects/entities/variants/organization.ts | Splits value vs type imports. |
| packages/data/src/objects/entities/variants/faction.ts | Splits value vs type imports. |
| packages/data/src/objects/entities/variants/candidate.ts | Splits value vs type imports. |
| packages/data/src/objects/entities/variants/alliance.ts | Splits value vs type imports. |
| packages/data/src/objects/entities/base/entity.ts | Splits value vs type imports. |
| packages/data/src/objects/election/election.ts | Splits value vs type imports (moves some to type-only). |
| packages/argument-condensation/tests/unit/handleQuestion.test.ts | Splits value vs type imports. |
| packages/argument-condensation/tests/condensation/condenseQuestions.test.ts | Splits value vs type imports. |
| packages/argument-condensation/src/core/utils/condensation/isSupportedQuestion.ts | Splits value vs type imports. |
| packages/argument-condensation/src/core/utils/condensation/getAndSliceComments.ts | Splits value vs type imports. |
| packages/argument-condensation/src/api.ts | Splits value vs type imports. |
| frontend/src/routes/[[lang=locale]]/candidate/login/+page.svelte | Splits value vs type imports. |
| frontend/src/routes/[[lang=locale]]/candidate/(protected)/questions/[questionId]/+page.svelte | Splits value vs type imports. |
| frontend/src/routes/[[lang=locale]]/candidate/(protected)/profile/+page.svelte | Splits value vs type imports and consolidates component imports. |
| frontend/src/routes/[[lang=locale]]/admin/login/+page.svelte | Splits value vs type imports. |
| frontend/src/routes/[[lang=locale]]/admin/(protected)/argument-condensation/+page.server.ts | Splits value vs type imports. |
| frontend/src/routes/[[lang=locale]]/(voters)/(located)/results/statistics/+page.svelte | Splits value vs type imports. |
| frontend/src/routes/[[lang=locale]]/(voters)/(located)/results/+page.svelte | Splits value vs type imports. |
| frontend/src/routes/[[lang=locale]]/(voters)/(located)/questions/category/[categoryId]/+page.svelte | Splits value vs type imports. |
| frontend/src/lib/utils/route/parseParams.ts | Splits value vs type imports. |
| frontend/src/lib/utils/route/filterPersistent.ts | Splits value vs type imports. |
| frontend/src/lib/utils/route/buildRoute.ts | Splits value vs type imports. |
| frontend/src/lib/utils/matching/imputeParentAnswers.ts | Splits value vs type imports (multi-line type import). |
| frontend/src/lib/utils/matches.ts | Splits value vs type imports. |
| frontend/src/lib/utils/entities.ts | Splits value vs type imports. |
| frontend/src/lib/server/api/adapters/local/localServerAdapter.ts | Splits value vs type imports. |
| frontend/src/lib/server/api/adapters/local/dataProvider/localServerDataProvider.ts | Splits value vs type imports (multi-line type import). |
| frontend/src/lib/server/admin/features/generateQuestionInfo.ts | Splits value vs type imports. |
| frontend/src/lib/server/admin/features/condenseArguments.ts | Splits value vs type imports. |
| frontend/src/lib/i18n/translations/index.ts | Adds newline after imports. |
| frontend/src/lib/i18n/init.ts | Splits value vs type imports. |
| frontend/src/lib/dynamic-components/questionHeading/QuestionHeading.svelte | Splits value vs type imports. |
| frontend/src/lib/dynamic-components/navigation/NavItem.svelte | Adds newline after imports. |
| frontend/src/lib/dynamic-components/footer/Footer.type.ts | Adds newline after imports. |
| frontend/src/lib/dynamic-components/feedback/popup/FeedbackPopup.svelte | Splits value vs type imports. |
| frontend/src/lib/dynamic-components/entityDetails/EntityInfo.svelte | Splits value vs type imports. |
| frontend/src/lib/dynamic-components/entityDetails/EntityDetails.svelte | Splits value vs type imports. |
| frontend/src/lib/dynamic-components/entityCard/EntityCard.svelte | Splits value vs type imports. |
| frontend/src/lib/dynamic-components/appLogo/AppLogo.type.ts | Adds newline after imports. |
| frontend/src/lib/contexts/voter/voter.ts | Converts imports to type-only. |
| frontend/src/lib/contexts/voter/nominationAndQuestionStore.ts | Splits value vs type imports. |
| frontend/src/lib/contexts/voter/matchStore.ts | Splits value vs type imports. |
| frontend/src/lib/contexts/voter/filters/buildQuestionFilter.ts | Splits value vs type imports. |
| frontend/src/lib/contexts/voter/answerStore.ts | Splits value vs type imports. |
| frontend/src/lib/contexts/utils/stackedStore.ts | Splits value vs type imports. |
| frontend/src/lib/contexts/utils/questionStore.ts | Splits value vs type imports. |
| frontend/src/lib/contexts/utils/questionCategoryStore.ts | Splits value vs type imports. |
| frontend/src/lib/contexts/utils/paramStore.ts | Splits value vs type imports. |
| frontend/src/lib/contexts/layout/layoutContext.ts | Splits value vs type imports. |
| frontend/src/lib/contexts/component/darkMode.ts | Splits value vs type imports. |
| frontend/src/lib/contexts/candidate/candidateUserDataStore.ts | Splits value vs type imports. |
| frontend/src/lib/contexts/app/tracking/trackingService.ts | Splits value vs type imports. |
| frontend/src/lib/contexts/app/survey.ts | Splits value vs type imports. |
| frontend/src/lib/contexts/app/getRoute.ts | Splits value vs type imports. |
| frontend/src/lib/contexts/app/appContext.ts | Splits value vs type imports. |
| frontend/src/lib/contexts/admin/jobStores.ts | Splits value vs type imports. |
| frontend/src/lib/components/warning/Warning.type.ts | Adds newline after imports. |
| frontend/src/lib/components/toggle/Toggle.type.ts | Adds newline after imports. |
| frontend/src/lib/components/tabs/Tabs.type.ts | Adds newline after imports. |
| frontend/src/lib/components/successMessage/SuccessMessage.type.ts | Adds newline after imports. |
| frontend/src/lib/components/questions/QuestionChoices.svelte | Splits value vs type imports. |
| frontend/src/lib/components/notification/Notification.svelte | Splits value vs type imports. |
| frontend/src/lib/components/loading/Loading.type.ts | Adds newline after imports. |
| frontend/src/lib/components/input/QuestionInput.svelte | Splits value vs type imports. |
| frontend/src/lib/components/input/Input.svelte | Splits value vs type imports. |
| frontend/src/lib/components/heroEmoji/HeroEmoji.type.ts | Adds newline after imports. |
| frontend/src/lib/components/headingGroup/PreHeading.type.ts | Adds newline after imports. |
| frontend/src/lib/components/headingGroup/PreHeading.svelte | Adds newline after imports. |
| frontend/src/lib/components/headingGroup/HeadingGroup.type.ts | Adds newline after imports. |
| frontend/src/lib/components/headingGroup/HeadingGroup.svelte | Adds newline after imports. |
| frontend/src/lib/components/errorMessage/ErrorMessage.type.ts | Adds newline after imports. |
| frontend/src/lib/components/entityTag/EntityTag.type.ts | Adds newline after imports. |
| frontend/src/lib/components/entityTag/EntityTag.svelte | Splits value vs type imports. |
| frontend/src/lib/components/entityFilters/enumerated/EnumeratedEntityFilter.svelte | Splits value vs type imports. |
| frontend/src/lib/components/electionTag/ElectionTag.type.ts | Adds newline after imports. |
| frontend/src/lib/components/constituencySelector/SingleGroupConstituencySelector.svelte | Splits value vs type imports. |
| frontend/src/lib/components/constituencySelector/ConstituencySelector.svelte | Splits value vs type imports. |
| frontend/src/lib/components/categoryTag/CategoryTag.type.ts | Adds newline after imports. |
| frontend/src/lib/candidate/components/passwordValidator/PasswordValidator.svelte | Splits value vs type imports. |
| frontend/src/lib/api/utils/translateHeroContent.ts | Splits value vs type imports. |
| frontend/src/lib/api/utils/parseResponse.test.ts | Splits value vs type imports. |
| frontend/src/lib/api/utils/filterEntitiesByNomination.ts | Splits value vs type imports. |
| frontend/src/lib/api/utils/filterEntitiesByNomination.test.ts | Splits value vs type imports. |
| frontend/src/lib/api/base/universalAdapter.ts | Splits value vs type imports. |
| frontend/src/lib/api/base/dataTypes.ts | Consolidates type imports from the same module. |
| frontend/src/lib/api/adapters/strapi/utils/parseQuestionType.ts | Splits value vs type imports. |
| frontend/src/lib/api/adapters/strapi/utils/parseOrganization.ts | Splits value vs type imports. |
| frontend/src/lib/api/adapters/strapi/utils/parseNominations.ts | Splits value vs type imports. |
| frontend/src/lib/api/adapters/strapi/utils/parseCandidate.ts | Splits value vs type imports. |
| frontend/src/lib/api/adapters/strapi/strapiAdapter.ts | Splits value vs type imports. |
| frontend/src/lib/api/adapters/strapi/dataProvider/strapiDataProvider.ts | Splits value vs type imports. |
| frontend/src/lib/api/adapters/apiRoute/apiRoutes.ts | Splits value vs type imports. |
| frontend/src/lib/api/adapters/apiRoute/apiRouteAdapter.ts | Splits value vs type imports. |
| backend/vaa-strapi/src/util/appSettings.ts | Splits value vs type imports. |
| backend/vaa-strapi/src/plugins/openvaa-admin-tools/admin/src/pages/HomePage.tsx | Consolidates multiple imports from the same module. |
| backend/vaa-strapi/src/functions/generateMockData.ts | Splits value vs type imports. |
| backend/vaa-strapi/src/extensions/documentation/documentation/1.0.0/full_documentation.json | Updates generated documentation metadata timestamp. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
backend/vaa-strapi/src/extensions/documentation/documentation/1.0.0/full_documentation.json
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply consistent, auto-fixable import formatting repo-wide.
Check off each of the following tasks as they are completed