Open
Conversation
…#727) Use Public Suffix List and punycode to accurately parse and display internationalized domains.
…jects, circular references and better error handling. Update merge.test.ts accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Add Unit Tests and Improve Core Utility Functions
These changes are implemented in the
add-unit-testsbranch (previously namedimprove-link-text-extraction).All updates are covered with comprehensive unit tests.
Closes
merge.tsWhat has been changed
This PR updates two core utility modules (
links.tsandmerge.ts) and adds thorough unit tests to ensure robust and correct behavior across various edge cases.links.tspsl(Public Suffix List) library to correctly extract registered domain names.punycodelibrary.https://subdomain.example.co.uk → Example).links.test.ts.merge.tsDateinstances preserved with.getTime())merge.test.tsfor flat, nested, and edge case scenarios.Checklist