feat(data-models): init data models for e2e user flow handling#8
Open
PhilippTheServer wants to merge 17 commits intoOpenTaberna:mainfrom
Open
feat(data-models): init data models for e2e user flow handling#8PhilippTheServer wants to merge 17 commits intoOpenTaberna:mainfrom
PhilippTheServer wants to merge 17 commits intoOpenTaberna:mainfrom
Conversation
maltonoloco
reviewed
Mar 4, 2026
maltonoloco
reviewed
Mar 4, 2026
| is_default: bool = Field( | ||
| default=False, description="Whether this is the default shipping address" | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
Maybe a field for additional address information like apartment, suite, unit, building, etc?
Also a field for state / region / province? Is often required in international addresses. And even if not it can be helpful
Contributor
Author
There was a problem hiding this comment.
No idea. If we need it we can add it easily later on
maltonoloco
reviewed
Mar 4, 2026
maltonoloco
reviewed
Mar 4, 2026
Contributor
maltonoloco
left a comment
maltonoloco
left a comment
There was a problem hiding this comment.
Thanks for your contribution. Regarding the customer feature, I have a few suggestions you might want to consider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
Description
init all database models as pydantic and orm model.
Motivation
To enable asynchronos work database models need to be defined first. Now the user flow can be implemented.
API Changes
Database Changes
Documentation
docs/)Testing
Checklist
env.exampleif needed