Closed
Conversation
LordAro
reviewed
Feb 15, 2025
Comment on lines
-15
to
+20
| This version of bottle is changed to fix a few issues with bottle: | ||
| - stdout/stderr was used instead of a logging infrastructure | ||
| - exceptions were not logged via logging infrastructure | ||
| - WSGIRefServer did not close server socket on exit | ||
| """ | ||
|
|
||
| from __future__ import with_statement | ||
| from __future__ import print_function | ||
| import sys | ||
|
|
||
| __author__ = 'Marcel Hellkamp' | ||
| __version__ = '0.12.25-eints' | ||
| __version__ = '0.13.2' |
Member
Author
There was a problem hiding this comment.
Some it did, some it didn't. So good point.
Member
Author
|
I am not going to upgrade bottle. The amount of serious CodeQL warnings is more than one, and overall I am very weirded out about the "I am going to do it different" approach bottle is showing. I was hoping this new version would comply a bit with more standerized approach of Python development (like, using a logger, instead of writing to stderr), but it doesn't. So I am just going to let this pass by. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.