-
Notifications
You must be signed in to change notification settings - Fork 5
#31 player hangar finalization #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/31-player-hangar
Are you sure you want to change the base?
#31 player hangar finalization #60
Conversation
| l.mode = 'single_player'; | ||
|
|
||
| l.scenograph.actors.map.get('Player One').setMode('vehicle'); | ||
| l.scenograph.actors.player = l.scenograph.actors.get('Player One'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be set in menu logic
| // Set the ship as ready. | ||
| l.current_scene.objects.demoShip.ready = true; | ||
| l.current_scene.objects.demoShip.camera_distance = l.current_scene.objects.demoShip.default_camera_distance + ( l.current_scene.room_depth / 2 ); | ||
| l.current_scene.objects.demoShip.mesh.userData.object.position.x = l.current_scene.objects.demoShip.mesh.position.x; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to do something about the demo ship, it probably needs to be split off with its own NPC AI so that it can fly around in "demo" mode while the player is in menu.
Main PR #59 is too large, making new PR to observe finalisation of #31