Skip to content

Fix accessibility on tabbed partial #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Stef-Rousset wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Fix accessibility on tabbed partial #1283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions decidim-core/app/views/decidim/pages/_tabbed.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@
<%= icon "arrow-down-s-line" %>
<%= icon "arrow-up-s-line" %>
</button>
<ul id="dropdown-menu-pages" class="vertical-tabs__list" role="menu">
<ul id="dropdown-menu-pages" class="vertical-tabs__list">
<% pages.each do |sibling| %>
<li class="<%= "is-active" if page == sibling %>" role="menuitem">
<%= link_to translated_attribute(sibling.title), page_path(sibling.slug), "aria-current": (page == sibling).to_s %>
<li class="<%= "is-active" if page == sibling %>">
<%= link_to translated_attribute(sibling.title), page_path(sibling.slug), "aria-current": page == sibling ? "page" : "false" %>
</li>
<% end %>
</ul>
Expand All @@ -43,3 +43,16 @@
</section>
</div>
<% end %>
<script>
// remove not necessary attribute on ul added on js
const ul = document.querySelector("#dropdown-menu-pages")
document.addEventListener("DOMContentLoaded", function(){
setTimeout(() => {
ul.removeAttribute("role")
}, 300)
})
// avoid change value of aria-hidden when clicking anywhere on window
window.addEventListener("click", function(){
ul.setAttribute("aria-hidden", "false")
})
</script>
Loading